Automated cherry pick of #1162: Fix for CVEs #1158: go version updates

[amacaskill]

Cherry pick of #1162 #1158 on release-1.7.

#1162: Fix for CVEs
#1158: go version updates

For details on the cherry pick process, see the cherry pick requests page.

None

[amacaskill]

/retest

[amacaskill]

Test started yesterday is still running for 11 hr

/retest

[amacaskill]

/assign @msau42

[amacaskill]

For 1.7, pull-gcp-compute-persistent-disk-csi-driver-verify Job for Verifying gofmt is also failing. This doesn't happen for 1.8. I'm not sure why this could be happening I will dig in more. We updated the go version, but I don't see any change in 1.8 change log since 1.7.3 that might cause this since we are backporting the go version changes to both 1.7 and 1.8.

The test fails with a confusing diff, and then says Please run hack/update-gofmt.sh. Is that something I want to do? @msau42

[msau42]

The dockerfile change controls the go version used to build the binary, but perhaps not the go version that's used to verify the go fmt. The go version probably got updated when the prow job image got updated to gcr.io/k8s-staging-test-infra/kubekins-e2e:v20230406-23cb1879e3-master

To prevent this from happening in the future, we may need to stop dependending on the go version of the prow job image.

[amacaskill]

How should I fix it this time?

[msau42]

I would go ahead and apply the formatting changes

[amacaskill]

/test pull-gcp-compute-persistent-disk-csi-driver-unit

[amacaskill]

I would go ahead and apply the formatting changes

Ok done! That fixed it

[msau42]

/lgtm

[msau42]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[amacaskill]

Now investigating why integration test failed still. I don't see an error. In the meantime I will retest

/retest

[msau42]

I don't think this is the cause of the integration test failure, but the multi-arch build failure probably needs a fix like kubernetes-sigs/sig-storage-local-static-provisioner#373

Nevermind the error I was thinking about only happens when you try to push images to a registry, which is not done as part of this workflow.

[msau42]

I think this was the error:

W0414 22:11:58.097] F0414 22:11:58.097443   89641 ginkgo.go:260] failed to run ginkgo tester: failed to validate pre-built binary kubectl (checked at "/go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/deploy/kubernetes/overlays/dev/_rundir/81484e6a-db0d-11ed-bf26-d6435f09a5e9/kubectl"): stat /go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/deploy/kubernetes/overlays/dev/_rundir/81484e6a-db0d-11ed-bf26-d6435f09a5e9/kubectl: no such file or directory
W0414 22:11:58.104] Error: exit status 255

[amacaskill]

I think this was the error:

W0414 22:11:58.097] F0414 22:11:58.097443   89641 ginkgo.go:260] failed to run ginkgo tester: failed to validate pre-built binary kubectl (checked at "/go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/deploy/kubernetes/overlays/dev/_rundir/81484e6a-db0d-11ed-bf26-d6435f09a5e9/kubectl"): stat /go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/deploy/kubernetes/overlays/dev/_rundir/81484e6a-db0d-11ed-bf26-d6435f09a5e9/kubectl: no such file or directory
W0414 22:11:58.104] Error: exit status 255

Hmm ok I'll look into that. I'm not sure what could cause that but I'll look through the recent changes to see if anything could've effected that.

Edit: Filestore had this problem too. They fixed it by using older version of kubetest2 because of a regression: https://github.com/kubernetes-sigs/gcp-filestore-csi-driver/pull/323/files. I applied this fix so fingers crossed this works.

[msau42]

Ok we should probably followup with kubetest folks on what the path forward should be.

[msau42]

/lgtm