prune changelog for 1.10 release #1182
Conversation
k8s-ci-robot
added
kind/documentation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amacaskill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/retest |
amacaskill
force-pushed
the
release-1.10
branch
from
f7b2ba2 to
f3491c8
Compare
There was a problem hiding this comment.
What is the intent of this change? Do we want the master branch changelog to reflect only the latest release changes, and that prior release changelogs are only kept in the release branches?
If so, have we confirmed that the changelogs in release branches are up to date? I recall seeing various changelog PRs that only updated them in the master branch.
EDIT: Nevermind I noticed this is against 1.10 branch.
CHANGELOG.md
Outdated
| See the [1.10 changelog in the master branch](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/CHANGELOG/CHANGELOG-1.0.md). |
There was a problem hiding this comment.
I'm confused, the text says 1.10 changelog but the link is pointing to the 1.0 changelog?
There was a problem hiding this comment.
Oops sorry I had 1.10 both places, then Sunny said to change to 1.0, but didn't change the text... Doing that now.
There was a problem hiding this comment.
Shouldn't it be the 1.10 changelog?
There was a problem hiding this comment.
That's what I had but I was told me to change to 1.0 so I changed it back. Let me ask why 1.0 was recommended.
There was a problem hiding this comment.
https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/CHANGELOG/CHANGELOG-1.10.md does not exist. I think we put everything in the 1.0 change log.
There was a problem hiding this comment.
I think the ordering is 1.9 -> 1.10 -1.11. We have never gone above 1.9 so this is a little confusing. But this is what kubernetes does: https://screenshot.googleplex.com/7p6BCrJbfhdU3Bn
I will create a changelog for 1.10 in master in a separate PR
There was a problem hiding this comment.
Sorry I was thinking that there is no major change in pd-csi so I did not realize we are bumping up the minor version.
There was a problem hiding this comment.
Are there any new features we're adding in 1.10?
There was a problem hiding this comment.
No new features but there are some fixes, mkfs and xfs_io error fixes etc, but these are/should be cherry-picked to release-1.9
There was a problem hiding this comment.
The volume cloning fix adds some new functionality around not having to specify allowedTopologies to get the cloning to work. Also we are updating go version to match k/k 1.27, but maybe that is not considered a new feature. But if that's not enough to justify a minor release, let me know and I can proceed with the patch release.
amacaskill
force-pushed
the
release-1.10
branch
from
f3491c8 to
31aa15c
Compare
amacaskill
force-pushed
the
release-1.10
branch
from
31aa15c to
0a066a0
Compare
| See the [1.10 changelog in the master branch](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/CHANGELOG/CHANGELOG-1.10.md). |
There was a problem hiding this comment.
https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/CHANGELOG/CHANGELOG-1.10.md doesn't exist yet. I will create this in master, but this PR doesn't need to wait for this I don't think.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
/kind documentation
/assign @sunnylovestiramisu