Skip to content

Update go version to 1.20 #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Update go version to 1.20 #1180

merged 1 commit into from
Apr 5, 2023

Conversation

sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Apr 4, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Update go version to match k/k 1.27: https://github.com/kubernetes/kubernetes/blob/master/.go-version

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update go version to 1.20.3 for k/k 1.27

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 4, 2023
@sunnylovestiramisu
Copy link
Contributor Author

/assign @msau42

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 4, 2023
@sunnylovestiramisu sunnylovestiramisu marked this pull request as ready for review April 4, 2023 16:56
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from leiyiz April 4, 2023 16:56
msau42
msau42 reviewed Apr 4, 2023
View reviewed changes
Dockerfile Outdated
@@ -14,7 +14,7 @@

ARG BUILDPLATFORM

FROM --platform=$BUILDPLATFORM golang:1.19.6 as builder
FROM --platform=$BUILDPLATFORM golang:1.20.2 as builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like 1.20.3 is being released today with a number of CVE fixes:
https://groups.google.com/g/golang-announce/c/71Wg3N0IZk0/m/xchF2bEZAgAJ

Copy link
Contributor Author

@sunnylovestiramisu sunnylovestiramisu Apr 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. But need to wait for it gets released so the integ tests can pass.

@sunnylovestiramisu
Copy link
Contributor Author

/retest

@msau42
Copy link
Contributor

msau42 commented Apr 5, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6c779af into kubernetes-sigs:master Apr 5, 2023
@sunnylovestiramisu
Copy link
Contributor Author

/cherry-pick release-1.9

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 10, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sunnylovestiramisu: new pull request created: #1181

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunnylovestiramisu sunnylovestiramisu deleted the fixEnv branch April 20, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@leiyiz leiyiz Awaiting requested review from leiyiz

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunnylovestiramisu @k8s-ci-robot @msau42 @k8s-infra-cherrypick-robot