Skip to content

Fix multiarch build #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Mar 3, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:
Multiarch build was failing with:

[builder 4/4] RUN GOARCH=$(echo linux/arm64 | cut -f2 -d '/') GCE_PD_CSI_STAGING_VERSION=v1.9.0-xxx make gce-pd-driver
21.78 # sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/cmd/gce-pd-csi-driver
21.78 loadinternal: cannot find runtime/cgo
gi21.78 /usr/local/go/pkg/tool/linux_amd64/link: running gcc failed: exit status 1

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Ran the following without errors:

docker buildx build  . --file=Dockerfile \
    --platform linux/arm64 \
    --build-arg STAGINGVERSION=test \
    --build-arg BUILDPLATFORM=linux/amd64 \
    --build-arg TARGETPLATFORM=linux/arm64  \
    --build-arg ARCH=arm64 

Does this PR introduce a user-facing change?:

Fix multiarch build

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 3, 2023
@k8s-ci-robot k8s-ci-robot requested review from mattcary and msau42 March 3, 2023 23:38
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2023
@sunnylovestiramisu
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 3, 2023
@sunnylovestiramisu sunnylovestiramisu marked this pull request as ready for review March 3, 2023 23:45
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2023
@k8s-ci-robot k8s-ci-robot requested a review from amacaskill March 3, 2023 23:45
@mattcary
Copy link
Contributor

mattcary commented Mar 3, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit b4f0a48 into kubernetes-sigs:master Mar 4, 2023
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2023
…k-of-#1164-upstream-release-1.9

Automated cherry pick of #1164: Fix multiarch build
@sunnylovestiramisu sunnylovestiramisu deleted the fixMultiArch branch March 6, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants