Skip to content

minor fixes on top of logging improvement #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2023
Merged

minor fixes on top of logging improvement #1145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/deviceutils/device-utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ func (m *deviceUtils) VerifyDevicePath(devicePaths []string, deviceName string)
var innerErr error
devicePath, innerErr = existingDevicePath(devicePaths)
if innerErr != nil {
e := fmt.Errorf("For disk %s failed to check for existing device path: %w", deviceName, innerErr)
e := fmt.Errorf("for disk %s failed to check for existing device path: %w", deviceName, innerErr)
klog.Errorf(e.Error())
return false, e
}
Expand Down Expand Up @@ -256,7 +256,7 @@ func (m *deviceUtils) VerifyDevicePath(devicePaths []string, deviceName string)

devFsSerial, innerErr := getDevFsSerial(devFsPath)
if innerErr != nil {
e := fmt.Errorf("Couldn't get serial number for disk %s at device path %s: %w", deviceName, devFsPath, innerErr)
e := fmt.Errorf("couldn't get serial number for disk %s at device path %s: %w", deviceName, devFsPath, innerErr)
klog.Errorf(e.Error())
return false, e
}
Expand All @@ -270,7 +270,7 @@ func (m *deviceUtils) VerifyDevicePath(devicePaths []string, deviceName string)
// A /dev/* path exists, but is either not a recognized /dev prefix type
// (/dev/nvme* or /dev/sd*) or devicePath is not mapped to the correct disk.
// Attempt a repair
klog.V(4).Infof("For disk %s and device path %s with mismatched serial number %q calling udevadmTriggerForDiskIfExists", deviceName, devFsPath, devFsSerial)
klog.Warningf("For disk %s and device path %s with mismatched serial number %q calling udevadmTriggerForDiskIfExists", deviceName, devFsPath, devFsSerial)
innerErr = udevadmTriggerForDiskIfExists(deviceName)
if innerErr != nil {
e := fmt.Errorf("failed to trigger udevadm fix of misconfigured disk for %q: %w", deviceName, innerErr)
Expand Down