Skip to content

Cherrypick #1138 - Improve logging for verification of device path #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2023
Merged

Cherrypick #1138 - Improve logging for verification of device path #1143

merged 1 commit into from
Feb 15, 2023
+28 −12

Conversation

saikat-royc
Copy link
Member

@saikat-royc saikat-royc commented Feb 15, 2023 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
This is a manual unclean cherrypick because the device utils moved to a new location in 1.9+ branches

Does this PR introduce a user-facing change?:

Improve logging for verification of device path

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2023
@saikat-royc saikat-royc force-pushed the release-1.8-cherrypick branch from d25dc59 to d10e432 Compare February 15, 2023 21:24
@saikat-royc
Copy link
Member Author

/retest

@saikat-royc
Copy link
Member Author

/assign @sunnylovestiramisu

@sunnylovestiramisu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2023
@saikat-royc saikat-royc mentioned this pull request Feb 15, 2023
Merged
@k8s-ci-robot k8s-ci-robot merged commit 8b509c4 into kubernetes-sigs:release-1.8 Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

@mattcary mattcary Awaiting requested review from mattcary

@msau42 msau42 Awaiting requested review from msau42

Assignees

@sunnylovestiramisu sunnylovestiramisu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saikat-royc @k8s-ci-robot @sunnylovestiramisu