Skip to content

Add change log for release-1.9 #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2023
Merged

Add change log for release-1.9 #1130

merged 1 commit into from
Feb 14, 2023

Conversation

sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Feb 13, 2023 •
edited by leiyiz
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:
For release-1.9

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 13, 2023
@sunnylovestiramisu
Copy link
Contributor Author

/assign @mattcary
/assign @leiyiz

leiyiz
leiyiz reviewed Feb 13, 2023
View reviewed changes
CHANGELOG/CHANGELOG-1.9.md Outdated
### Bug or Regression

- Add udevadm binary in the container image. ([#1072](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1072), [@jenting](https://github.com/jenting))
- Logging for gRPC call is now limited to 10000 char by default, and configurable with flag --grpc-log-char-cap ([#1085](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1085), [@leiyiz](https://github.com/leiyiz))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsadoyan can you add this to 1.8.2 release note? seem like it's missing from the 1.8.2 release note

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the same time I will remove this line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think pull/1085 was cherrypicked into 1.8.2, was it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was. people who wants things to be cherrypicked should cherry pick PRs, which was me. #1111 cherry picked it

@sunnylovestiramisu
Copy link
Contributor Author

Baking: https://k8s-testgrid.appspot.com/provider-gcp-compute-persistent-disk-csi-driver#Kubernetes%20Master%20Driver%20Latest%20Release%20Candidate

leiyiz
leiyiz reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@leiyiz leiyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leiyiz, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 14, 2023
@leiyiz
Copy link
Contributor

leiyiz commented Feb 14, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit ebaa88a into kubernetes-sigs:master Feb 14, 2023
@sunnylovestiramisu sunnylovestiramisu deleted the changelog-1.9 branch February 14, 2023 21:57
@sunnylovestiramisu sunnylovestiramisu mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsadoyan hsadoyan hsadoyan left review comments

@leiyiz leiyiz leiyiz left review comments

@amacaskill amacaskill Awaiting requested review from amacaskill

Assignees

@mattcary mattcary

@leiyiz leiyiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sunnylovestiramisu @k8s-ci-robot @leiyiz @hsadoyan @mattcary