-
Notifications
You must be signed in to change notification settings - Fork 159
CVE-2022-41717: update golang.org/x/net version #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RomanBednar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4627642
to
964ab2c
Compare
@RomanBednar: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -1,4 +1,4 @@ | |||
// Copyright 2023 Google LLC. | |||
// Copyright 2022 Google LLC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is very suspicious. There should be no changes in vendor/google.golang.org/api/compute/v0.beta/compute-gen.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the client files were manually updated in #1101
@sunnylovestiramisu @mattcary I believe these were custom-generated sdk files right? I think that means we should manually revert the change in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We manually generated the beta client intentionally to have the iops field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunnylovestiramisu I see, however I noticed the vulnerable package got bumped recently in scope of this change. Closing this PR as it's no longer needed.
What type of PR is this?
/kind bug
What this PR does / why we need it:
golang.org/x/net module needs to be updated to v.0.4.0 or higher to resolve this vulnerability: https://pkg.go.dev/vuln/GO-2022-1144
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: