Resolve disk name collisions for attached regional disks #111
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
| status.Error(codes.Internal, fmt.Sprintf("error getting device name: %v", err)) | ||
| } | ||
|
|
||
| devicePaths := ns.DeviceUtils.GetDiskByIdPaths(deviceName, partition) | ||
| devicePath, err := ns.DeviceUtils.VerifyDevicePath(devicePaths) |
There was a problem hiding this comment.
did you merge that udev fix that used scsi_id and validated the device name? I wonder if that will have issues with this change.
There was a problem hiding this comment.
hmm I'm not really sure what you're talking about. I have a vague memory of something like that but I can't find a PR about it...
There was a problem hiding this comment.
do you mean the change you made to k8s/k8s where you try to rerun udevadm trigger a bunch of times after doing some file parsing for validation? If so, then no I haven't merged that
There was a problem hiding this comment.
ok we may have to revisit this in that PR then
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Fixes: #109
/assign @msau42
/assign @verult