-
Notifications
You must be signed in to change notification settings - Fork 159
added labels for namespace and pvc names for a pv #1090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @Sneha-at! |
Hi @Sneha-at. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/easycla |
/ok-to-test |
/retest |
Can you clarify in the release note that the added labels duplicate what's added to the description? |
/test pull-gcp-compute-persistent-disk-csi-driver-sanity |
Hey! So I have just fixed and re-enabled the sanity tests for PD so if you merge the latest commits from master into this branch it should pass the sanity tests |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, Sneha-at The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
The PR adds namespace and PVC names as labels to PVs
Which issue(s) this PR fixes:
Fixes #1064
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Yes