WIP Mock up: Add rpc-specific backoff #1089
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Makes backoff criteria RPC-specific so unpublish failures don't cause backoffs for publish, and vice-versa
This fixes a sanity test that is currently failing. The scenario of the failing sanity test ("should fail when the volume is already published but is incompatible"):
ControllerUnpublish not permitted on node "projects/test-project/zones/country-region-zone/instances/test-name" due to backoff condition
because of Step 3.This change makes it so the failure from Step 3 does not affect Step 4.
Which issue(s) this PR fixes:
Fixes #990
Special notes for your reviewer:
Does this PR introduce a user-facing change?: