Upgrade klog v1 to v2 and fix error wrapping

[sunnylovestiramisu]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Simiar to gcp-filestore-csi-driver/pr/381. In V1 klog.Errorf does not support %w but we need to unwrap the error correctly.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

[k8s-ci-robot]

Hi @sunnylovestiramisu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[saikat-royc]

/ok-to-test

[sunnylovestiramisu]

/retest

[sunnylovestiramisu]

Verified integration test logs:

Pod log: http://shortn/_YyBlskh1D6

klog.V(4).Infof("NodePublishVolume succeeded on volume...)
klog.Errorf("Failed to disabled device...)

[msau42]

It looks like the pdcsi driver doesn't have the same isUserError logic that filestore has and it is returning Internal error code in a lot of places:

gcp-compute-persistent-disk-csi-driver/pkg/gce-pd-csi-driver/controller.go

Line 341 in f19add5

return nil, status.Error(codes.Internal, fmt.Sprintf("CreateVolume failed to create single zonal disk %#v: %v", name, err))

So I think this PR can concentrate on switching to klog v2, but there is more work required to propagate user error codes.

[sunnylovestiramisu]

Will address that in another pr, this is converting klog to klogv2 so we can use %w. A lot of these fmt.Sprintf errors got kloged with %v before reaching this step.

[msau42]

/lgtm
/approve
/release-note-none

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@sunnylovestiramisu: cannot checkout branch-1.7: error checking out branch-1.7: exit status 1. output: error: pathspec 'branch-1.7' did not match any file(s) known to git

In response to this:

/cherry-pick branch-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sunnylovestiramisu]

/cherry-pick release-1.7

[k8s-infra-cherrypick-robot]

@sunnylovestiramisu: #1084 failed to apply on top of branch "release-1.7":

Applying: Upgrade klog v1 to v2 and fix error wrapping
Using index info to reconstruct a base tree...
M	cmd/gce-pd-csi-driver/main.go
M	go.mod
M	go.sum
M	pkg/gce-cloud-provider/compute/fake-gce.go
M	pkg/gce-cloud-provider/compute/gce-compute.go
M	pkg/gce-cloud-provider/compute/gce.go
M	pkg/gce-pd-csi-driver/controller.go
M	pkg/gce-pd-csi-driver/node.go
M	pkg/mount-manager/device-utils.go
M	pkg/mount-manager/safe-mounter-v1_windows.go
M	pkg/mount-manager/safe-mounter-v1beta_windows.go
M	pkg/resizefs/resizefs_linux.go
M	test/e2e/tests/resize_e2e_test.go
M	test/e2e/tests/setup_e2e_test.go
M	test/e2e/tests/single_zone_e2e_test.go
M	test/e2e/utils/utils.go
M	test/k8s-integration/main.go
M	test/k8s-integration/version.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Removing vendor/k8s.io/klog/klog_file.go
Removing vendor/k8s.io/klog/klog.go
Removing vendor/k8s.io/klog/code-of-conduct.md
Removing vendor/k8s.io/klog/SECURITY_CONTACTS
Removing vendor/k8s.io/klog/RELEASE.md
Removing vendor/k8s.io/klog/README.md
Removing vendor/k8s.io/klog/OWNERS
Removing vendor/k8s.io/klog/LICENSE
Removing vendor/k8s.io/klog/CONTRIBUTING.md
Removing vendor/k8s.io/klog/.travis.yml
Auto-merging test/k8s-integration/version.go
Auto-merging test/k8s-integration/main.go
Auto-merging test/e2e/utils/utils.go
CONFLICT (content): Merge conflict in test/e2e/utils/utils.go
Auto-merging test/e2e/tests/single_zone_e2e_test.go
CONFLICT (content): Merge conflict in test/e2e/tests/single_zone_e2e_test.go
Auto-merging test/e2e/tests/setup_e2e_test.go
Auto-merging test/e2e/tests/resize_e2e_test.go
Auto-merging pkg/resizefs/resizefs_linux.go
Auto-merging pkg/mount-manager/safe-mounter-v1beta_windows.go
Auto-merging pkg/mount-manager/safe-mounter-v1_windows.go
Auto-merging pkg/mount-manager/device-utils.go
Auto-merging pkg/gce-pd-csi-driver/node.go
CONFLICT (content): Merge conflict in pkg/gce-pd-csi-driver/node.go
Auto-merging pkg/gce-pd-csi-driver/controller.go
Auto-merging pkg/gce-cloud-provider/compute/gce.go
Auto-merging pkg/gce-cloud-provider/compute/gce-compute.go
Auto-merging pkg/gce-cloud-provider/compute/fake-gce.go
Auto-merging go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging cmd/gce-pd-csi-driver/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Upgrade klog v1 to v2 and fix error wrapping
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.