-
Notifications
You must be signed in to change notification settings - Fork 159
Fix resize-related sanity test failures #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resize-related sanity test failures #1083
Conversation
Hi @judemars. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test (there's a bigger discussion around sanity checks on another thread) |
/retest |
1 similar comment
/retest |
5a24dcd
to
23eed3f
Compare
f2fcb35
to
7435b75
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: judemars, mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Our sanity tests are currently failing 4 test cases: 1 because of go/pdcsi-oss-driver/issues/990 to be addressed in a follow up in another repo, and 3 others with the error:
This PR fixes the latter 3 failures by mocking out the resize method.
Note this also required moving deviceutils into its own pkg to avoid a circular dependency from mountmanager (device utils) -> resize -> mountmanager (windows).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: