-
Notifications
You must be signed in to change notification settings - Fork 159
add beta/v1 suffix to passed-in compute endpoint #1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add beta/v1 suffix to passed-in compute endpoint #1080
Conversation
Hi @judemars. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/retest |
@judemars: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok--to-test |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: judemars, mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest e2e failure:
k8s integration failure:
|
/retest k8s integration finally succeeded but e2e still failing with:
|
/retest FYI I filed a bug for the oauth flakes at http://go/pdcsi-oss-driver/issues/1082 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This is a follow up to github.com//pull/1077 which added a configurable compute endpoint to pdcsi driver. It adds the /compute/{beta/v1} suffix to the endpoint since we can't expect that from the caller.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: