Add provisionedIops for pd-extreme #1079

sunnylovestiramisu · 2022-11-14T19:20:33Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Support pd-extreme with provisionedIops, please see pd-extreme

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

The current pd-extreme restrictions:

Extreme persistent disks are zonal only. You cannot create regional extreme persistent disks.
You cannot attach multiple VM instances in read-only mode to an extreme persistent disk.
You cannot create an image or machine image from an extreme persistent disk.
You cannot clone an extreme persistent disk.

Does this PR introduce a user-facing change?:


Pass in ProvisionedIOPSOnCreate as a parameter for CreateVolume

k8s-ci-robot · 2022-11-14T19:20:41Z

Hi @sunnylovestiramisu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mattcary · 2022-11-14T19:22:03Z

/ok-to-test

mattcary

Let's also add the changes to gce-compute in this same PR.

README.md

pkg/common/parameters.go

judemars · 2022-11-30T20:04:15Z

Hey there! Just letting you know that I have just fixed and re-enabled the sanity tests for PD in go/pdcsi-oss-driver/issues/990 so if you experience failures in your sanity test PR gate build because you're on an old branch before the tests were fixed, merging the latest commits from master into this branch it should make them pass. Let me know if you have any questions!

sunnylovestiramisu · 2022-12-01T19:18:35Z

/assign @mattcary

sunnylovestiramisu · 2022-12-08T00:10:45Z

/retest

sunnylovestiramisu · 2022-12-08T21:32:05Z

pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration test failed with

I1208 20:16:57.033]     Dec  8 20:16:56.333: INFO: At 2022-12-08 20:11:39 +0000 UTC - event for csi-gcepd-sc-extreme--no-volumesnapshotclassjltvh-cloned: {pd.csi.storage.gke.io_e2e-test-prow-minion-group-5v0r_488ec745-8f4f-4b8e-bb07-e8ff64d95cb6 } ProvisioningFailed: failed to provision volume with StorageClass "multivolume-2380-e2e-sc9n4x2": rpc error: code = Internal desc = CreateVolume failed to create single zonal disk "pvc-2a6e4167-27ea-4eff-b8f7-e40b8fdd7137": failed to insert zonal disk: unknown Insert disk error: googleapi: Error 400: Cloning is not supported for disks of pd-extreme type., badRequest

which is expected because pd-extreme does not support cloning.

Failed tests

sunnylovestiramisu · 2022-12-14T21:00:11Z

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

test/k8s-integration/driver-config.go

test/k8s-integration/main.go

sunnylovestiramisu · 2022-12-14T23:48:32Z

The k8s integration success run with pd-extreme is in:
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_gcp-compute-persistent-disk-csi-driver/1079/pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration/1603132775324454912/

The discussion is that we are not checking in the integration test but we can swap the storage class to --storageclass-files=sc-extreme.yaml in test/run-k8s-integration.sh

test/k8s-integration/driver-config.go

mattcary · 2022-12-15T00:46:20Z

test/k8s-integration/driver-config.go

@@ -127,10 +127,12 @@ func generateDriverConfigFile(testParams *testParameters) (string, error) {
 		snapshotClassName = "no-volumesnapshotclass"
 	}

-	caps = append(caps, "pvcDataSource")
+	if strings.Contains(testParams.storageClassFile, "sc-standard") {


I think we want to check pvcDataSource on everything but extreme, not just on standard.

(if we picked one we'd do balanced anyway)

I was thinking hyperdisk also does not support cloning?

We'll cross that bridge when we get to it. I think some SKUs will.

mattcary · 2022-12-15T00:58:08Z

/lgtm
/approve

k8s-ci-robot · 2022-12-15T00:58:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mattcary]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…k-of-#1079-#1101-upstream-release-1.8 Automated cherry pick of #1079: Add provisionedIops for pd-extreme #1101: Add provisionedThroughput for hyperdisk

…k-of-#1079-#1101-#1128-upstream-release-1.7 Automated cherry pick of #1079: Add provisionedIops for pd-extreme #1128: Change iops params directly convert string to int64

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2022

k8s-ci-robot requested a review from jingxu97 November 14, 2022 19:20

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 14, 2022

k8s-ci-robot requested a review from saad-ali November 14, 2022 19:20

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 14, 2022

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2022

mattcary reviewed Nov 14, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

pkg/common/parameters.go Outdated Show resolved Hide resolved

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2022

sunnylovestiramisu closed this Nov 18, 2022

sunnylovestiramisu force-pushed the master branch from 02fe8b3 to febd972 Compare November 18, 2022 21:10

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2022

sunnylovestiramisu reopened this Nov 18, 2022

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2022

sunnylovestiramisu force-pushed the master branch 2 times, most recently from 70de6e4 to 1e548fd Compare November 29, 2022 18:03

k8s-ci-robot assigned mattcary Dec 1, 2022

sunnylovestiramisu force-pushed the master branch 3 times, most recently from 108471e to 8c9ec12 Compare December 2, 2022 19:23

k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 2, 2022

sunnylovestiramisu marked this pull request as ready for review December 8, 2022 04:49

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 8, 2022

k8s-ci-robot requested review from mattcary and saikat-royc December 8, 2022 04:49

sunnylovestiramisu force-pushed the master branch from be8128c to 5116d0b Compare December 8, 2022 21:30

sunnylovestiramisu force-pushed the master branch from 5116d0b to 8b40ced Compare December 9, 2022 17:42

sunnylovestiramisu added 2 commits December 13, 2022 09:54

Add provisionedIops for pd-extreme

3f3ed63

Test pd-extreme e2e test case

a11cd4b

sunnylovestiramisu force-pushed the master branch 2 times, most recently from 71b0fbc to 252c7d2 Compare December 14, 2022 20:59

mattcary reviewed Dec 14, 2022

View reviewed changes

test/k8s-integration/driver-config.go Outdated Show resolved Hide resolved

test/k8s-integration/driver-config.go Show resolved Hide resolved

test/k8s-integration/main.go Outdated Show resolved Hide resolved

sunnylovestiramisu force-pushed the master branch 2 times, most recently from c439258 to 088dfa1 Compare December 15, 2022 00:00

mattcary reviewed Dec 15, 2022

View reviewed changes

test/k8s-integration/driver-config.go Outdated Show resolved Hide resolved

mattcary reviewed Dec 15, 2022

View reviewed changes

Test pd-extreme k8s integration

1634555

sunnylovestiramisu force-pushed the master branch from 088dfa1 to 1634555 Compare December 15, 2022 00:51

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022

k8s-ci-robot merged commit be08243 into kubernetes-sigs:master Dec 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add provisionedIops for pd-extreme #1079

Add provisionedIops for pd-extreme #1079

sunnylovestiramisu commented Nov 14, 2022 •

edited

Loading

k8s-ci-robot commented Nov 14, 2022

mattcary commented Nov 14, 2022

mattcary left a comment

judemars commented Nov 30, 2022

sunnylovestiramisu commented Dec 1, 2022

sunnylovestiramisu commented Dec 8, 2022

sunnylovestiramisu commented Dec 8, 2022 •

edited

Loading

sunnylovestiramisu commented Dec 14, 2022

sunnylovestiramisu commented Dec 14, 2022 •

edited

Loading

mattcary Dec 15, 2022

sunnylovestiramisu Dec 15, 2022

mattcary Dec 15, 2022

mattcary commented Dec 15, 2022

k8s-ci-robot commented Dec 15, 2022

Add provisionedIops for pd-extreme #1079

Add provisionedIops for pd-extreme #1079

Conversation

sunnylovestiramisu commented Nov 14, 2022 • edited Loading

k8s-ci-robot commented Nov 14, 2022

mattcary commented Nov 14, 2022

mattcary left a comment

Choose a reason for hiding this comment

judemars commented Nov 30, 2022

sunnylovestiramisu commented Dec 1, 2022

sunnylovestiramisu commented Dec 8, 2022

sunnylovestiramisu commented Dec 8, 2022 • edited Loading

sunnylovestiramisu commented Dec 14, 2022

sunnylovestiramisu commented Dec 14, 2022 • edited Loading

mattcary Dec 15, 2022

Choose a reason for hiding this comment

sunnylovestiramisu Dec 15, 2022

Choose a reason for hiding this comment

mattcary Dec 15, 2022

Choose a reason for hiding this comment

mattcary commented Dec 15, 2022

k8s-ci-robot commented Dec 15, 2022

sunnylovestiramisu commented Nov 14, 2022 •

edited

Loading

sunnylovestiramisu commented Dec 8, 2022 •

edited

Loading

sunnylovestiramisu commented Dec 14, 2022 •

edited

Loading