Skip to content

Add udevadm binary to container image #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2022
Merged

Add udevadm binary to container image #1072

merged 3 commits into from
Nov 15, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Nov 7, 2022 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Address the error message

udevadmChangeToDrive: udevadm trigger failed for drive "/dev/sdh" with output : exec: "udevadm": executable file not found in $PATH.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

The udevadm binary does not exist in the container image.

Does this PR introduce a user-facing change?:

Add udevadm binary in the container image.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @jenting. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 7, 2022
@jenting jenting marked this pull request as ready for review November 7, 2022 09:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2022
@jenting
Copy link
Contributor Author

jenting commented Nov 7, 2022

/assign @mattcary

@jenting jenting changed the title Add udevadm binary Add udevadm binary to container image Nov 7, 2022
@mattcary
Copy link
Contributor

mattcary commented Nov 8, 2022

/assign @amacaskill

It looks like we missed this when converting to distroless?

Thanks @jenting !

@mattcary
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 11, 2022
@amacaskill
Copy link
Member

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2022
@mattcary
Copy link
Contributor

I think the test is failing due to what's fixed in #1075

@mattcary
Copy link
Contributor

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

@jenting
Copy link
Contributor Author

jenting commented Nov 15, 2022

@mattcary
Is this PR okay to be merged?

@mattcary
Copy link
Contributor

Thanks, looks like my fix got merged and the tests are passing.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jenting, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 82b39c5 into kubernetes-sigs:master Nov 15, 2022
@mattcary mattcary mentioned this pull request Dec 3, 2022
Merged
mattcary added a commit that referenced this pull request Dec 3, 2022
@mattcary
Merge pull request #1095 from mattcary/automated-cherry-pick-of-#1072…
cb28a0f 
…-upstream-release-1.7

Automated cherry pick of #1072: Add udevadm to container image
@mattcary mattcary mentioned this pull request Dec 5, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 5, 2022
@k8s-ci-robot
Merge pull request #1097 from mattcary/automated-cherry-pick-of-#1072…
68b9ee5 
…-upstream-release-1.8

Automated cherry pick of #1072: Add udevadm to container image
@jenting jenting deleted the udevadm-binary branch February 24, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@mattcary mattcary

@amacaskill amacaskill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jenting @k8s-ci-robot @mattcary @amacaskill