Support add the snapshot labels to images

[jenting]

What type of PR is this?

/kind feature

What this PR does / why we need it:

We use labels to filter the GCP images.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Add parameters to your VolumeSnapshotClass like so:

apiVersion: snapshot.storage.k8s.io/v1
kind: VolumeSnapshotClass
metadata:
  name: csi-gce-pd-snapshot-class
parameters:
  labels: cluster=preview,region=us,custom-label=awesome
  snapshot-type: images
driver: pd.csi.storage.gke.io
deletionPolicy: Delete

Does this PR introduce a user-facing change?:

Support setting snapshot labels to Images

[k8s-ci-robot]

Welcome @jenting!

It looks like this is your first PR to kubernetes-sigs/gcp-compute-persistent-disk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gcp-compute-persistent-disk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jenting. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jenting]

@mattcary PTAL

[jenting]

/assign @mattcary

[mattcary]

/ok-to-test

I'll take a look at this shortly, thanks for the ping.

[mattcary]

Ah, I didn't realize we just forgot to do the same with with disk image labels that we do with snapshots. Thanks for this change!

It looks like we already have unit tests in https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/pkg/common/parameters_test.go; can you add a sort-of-e2e test by adding labels to https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/test/k8s-integration/config/image-volumesnapshotclass.yaml?

I don't think it will be easy to validate the labels are applied, but at least we'll catch if things will crash if they're used.

[jenting]

can you add a sort-of-e2e test by adding labels to https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/test/k8s-integration/config/image-volumesnapshotclass.yaml?

I added to pd-volumesnapshotclass.yaml and image-volumesnapshotclass.yaml.

[mattcary]

Awesome, thanks again for your PR.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jenting, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mattcary]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment