Skip to content

Test contexts are now initialized once on startup in parallel instead of per-test, Chose a better boot disk image. #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2018
Merged

Test contexts are now initialized once on startup in parallel instead of per-test, Chose a better boot disk image. #104

merged 2 commits into from
Aug 28, 2018

Conversation

davidz627
Copy link
Contributor

Fixes: #101
Fixes: #97

/assign @msau42

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 27, 2018
@davidz627 davidz627 changed the title Test contexts are now initialized once on startup instead of per-test, Chose a better boot disk image Test contexts are now initialized once on startup in parallel instead of per-test, Chose a better boot disk image. Aug 27, 2018
@davidz627
Copy link
Contributor Author

@msau42 sorry this PR kind of became multifaceted, I wanted to make the tests faster and I just couldn't stop

msau42
msau42 reviewed Aug 28, 2018
View reviewed changes
test/e2e/tests/setup_e2e_test.go
func getRandomTestContext() *remote.TestContext {
Expect(testContexts).ToNot(BeEmpty())
rn := rand.Intn(len(testContexts))
return testContexts[rn]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any issue if multiple tests run in parallel and choose the same context?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe so, since the driver can handle multiple incoming requests and all volume's should be unique due to UUID's. If there is a parallelism issue here it would be with the driver, not the tests and that is something we'd want to catch if it existed.

@msau42
Copy link
Contributor

msau42 commented Aug 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit a1d6f88 into kubernetes-sigs:master Aug 28, 2018
@davidz627 davidz627 deleted the fix/testImage branch August 28, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@verult verult Awaiting requested review from verult

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidz627 @k8s-ci-robot @msau42