Made unmounting more robust #103
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
pkg/gce-pd-csi-driver/utils.go
Outdated
| @@ -58,3 +63,97 @@ func logGRPC(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, h | |||
| } | |||
| return resp, err | |||
| } | |||
|
|
|||
| // UnmountMountPoint is a common unmount routine that unmounts the given path and | |||
There was a problem hiding this comment.
This looks like it's straight from kubernetes volume util. Is there anyway we can use that instead?
There was a problem hiding this comment.
yea, I was wondering whether I should copy-paste or just import. Since that file has a bunch of random very Kubernetes specific code too and I'm not sure what the status is of that code.
I think I overheard at some point we're only "supposed to" import kubernetes code if its in "staging" (im not 100% sure what that means)
There was a problem hiding this comment.
We're in the process of refactoring the mount library to make it easier to import. If you import it now, it means that you will probably pull in a lot of unnecessary kubernetes dependencies.
k8s-ci-robot
added
size/XXL
|
@msau42 changed this to an import instead |
|
/retest |
davidz627
force-pushed
the
fix/Unmount
branch
from
2ec3790 to
8227a96
Compare
davidz627
force-pushed
the
fix/Unmount
branch
from
8227a96 to
0309c07
Compare
|
@msau42 rebased and comments addressed |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
Fixes: #96
/assign @msau42