Skip to content

backoff per {node,disk} pair instead of just node} #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2022
Merged

backoff per {node,disk} pair instead of just node} #1028

merged 1 commit into from
Jul 25, 2022

Conversation

mattcary
Copy link
Contributor

@mattcary mattcary commented Jul 22, 2022 •
edited
Loading

I'll create an issue on this repo and update this message to point to it.

/kind bug

Fixes #1029

Improve backoff to be per-node and disk to avoid missing disks from blocking all operations

/assign @saikat-royc

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 22, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2022
@mattcary mattcary force-pushed the perdisk branch 2 times, most recently from f205754 to f908ed9 Compare July 22, 2022 22:52
@saikat-royc
Copy link
Member

LGTM after a minor comment.

@mattcary
backoff per {node,disk} pair instead of just node}
11611ed 
Change-Id: I9a2ae648b6f76df1d46bd0a7c992e4ce37f9f4af
@saikat-royc
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mattcary,saikat-royc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e84da89 into kubernetes-sigs:master Jul 25, 2022
This was referenced Jul 30, 2022
Closed
Merged
@judemars judemars mentioned this pull request Nov 17, 2022
Closed
@jsafrane jsafrane mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikat-royc saikat-royc saikat-royc left review comments

@davidz627 davidz627 Awaiting requested review from davidz627

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@saikat-royc saikat-royc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing disks causes nodes to stick due to backoff
3 participants
@mattcary @saikat-royc @k8s-ci-robot