Skip to content

Remove passwd- file to make CIS benchmark happy #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

mattcary
Copy link
Contributor

/kind bug

In order to pass the CIS benchmark, the /etc/passwd- file can only be root-readable. Even better is to just remove it altogether, as the PR does.

Pass [CIS benchmark](https://www.cisecurity.org/cis-benchmarks/) by cleaning up /etc/passwd- in the driver image.

/assign @amacaskill

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from davidz627 and verult July 16, 2022 00:30
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2022
@mattcary
Copy link
Contributor Author

Could the failure be due to PSP deprecation?

W0716 01:03:47.514] resource mapping not found for name: "csi-gce-pd-controller-psp" namespace: "" from "STDIN": no matches for kind "PodSecurityPolicy" in version "policy/v1beta1"
W0716 01:03:47.514] ensure CRDs are installed first
W0716 01:03:47.514] resource mapping not found for name: "csi-gce-pd-node-psp" namespace: "" from "STDIN": no matches for kind "PodSecurityPolicy" in version "policy/v1beta1"
W0716 01:03:47.514] ensure CRDs are installed first
W0716 01:03:47.515] resource mapping not found for name: "csi-gce-pd-node-psp-win" namespace: "" from "STDIN": no matches for kind "PodSecurityPolicy" in version "policy/v1beta1"
W0716 01:03:47.515] ensure CRDs are installed first
W0716 01:03:47.516] E0716 01:03:47.515793    8031 main.go:398] failed to delete driver: failed to delete driver: exit status 1

@mattcary
Copy link
Contributor Author

I think it is, I'm trying to pin the tests for this branch to 1.21 to see if that allows us to test.

Change-Id: If655240c96b0bed20803185fe5ed7c40b25f2cf9
@k8s-ci-robot
Copy link
Contributor

@mattcary: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration 7694652 link true /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mattcary
Copy link
Contributor Author

Sigh, it's failing now because hack/ginkgo-e2e.sh in release-1.21 has outdated flags. I'll have to force-push this and we'll run through the internal GKE tests.

@mattcary mattcary merged commit 3c818dc into kubernetes-sigs:release-1.3 Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants