Fixed project setup scripts #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
davidz627
force-pushed
the
fix/projectSetup
branch
from
2eaa61b to
4e7b051
Compare
msau42
reviewed
Jun 19, 2018
deploy/setup-project.sh
Outdated
| IAM_NAME="$GCEPD_SA_NAME@$PROJECT.iam.gserviceaccount.com" | ||
|
|
||
| # Cleanup old Service Account and Key | ||
| rm -f $SA_FILE |
There was a problem hiding this comment.
One more recommendation I found was to put quotes around all variables, to handle things like spaces in filenames
davidz627
force-pushed
the
fix/projectSetup
branch
from
4e7b051 to
84fad45
Compare
msau42
reviewed
Jun 19, 2018
test/run-tests.sh
Outdated
| readonly PKGDIR=github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver | ||
|
|
||
| go test -timeout 30s ${PKGDIR}/test/sanity/ -run ^TestSanity$ | ||
| go run $GOPATH/src/${PKGDIR}/test/remote/run_remote/run_remote.go --logtostderr --v 2 --project "${PROJECT}" --zone "${ZONE}" --ssh-env gce --delete-instances=false --cleanup=false --results-dir=my_test |
davidz627
force-pushed
the
fix/projectSetup
branch
from
84fad45 to
f148d7a
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some cleanup to project setup scripts, corrected role and added TODO for IAM scope reduction.
/assign @msau42
Feel free to use updated scripts for yourself too