Skip to content

Improve cloud provider layering #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
msau42 opened this issue Jul 17, 2018 · 4 comments
Closed

Improve cloud provider layering #70

msau42 opened this issue Jul 17, 2018 · 4 comments
Milestone
Beta

Comments

@msau42
Copy link
Contributor

msau42 commented Jul 17, 2018

It may be cleaner to encapsulate the WaitForOp in the cloud provider CreateDisk method, instead of having the driver do it. This is more in line with how the in-tree driver is implemented.
@msau42
Copy link
Contributor Author

msau42 commented Jul 17, 2018

As a side note, could you just use the in-tree cloud provider code?

@davidz627
Copy link
Contributor

I thought we wanted to deprecate the in-tree cloud provider code?

@msau42
Copy link
Contributor Author

msau42 commented Jul 17, 2018

It's going to be moved out of tree eventually, but the code/interfaces should be the same?

@davidz627 davidz627 added this to the Beta milestone Jul 18, 2018
@davidz627
Copy link
Contributor

Kubernetes in-tree cloud-provider interface is too bloated to use successfully. I have updated the cloud provider in this pr: #84

jsafrane pushed a commit to jsafrane/gcp-compute-persistent-disk-csi-driver that referenced this issue Apr 16, 2025
@openshift-merge-bot
Merge pull request kubernetes-sigs#70 from dfajmon/rebase-v1.14.2
3e91f91 
STOR-2012: Rebase to upstream v1.14.2 for OCP 4.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Beta
Development

No branches or pull requests
2 participants
@davidz627 @msau42