setup-project.sh should skip keys creation step for noauth overlay

[saikat-royc]

In https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/deploy/setup-project.sh,
gcloud iam service-accounts keys create step should be skipped when using a noauth overlay.

[mattcary]

We already have a CREATE_SA variable to control the project setup.

I was under the impression that this script would only be run once, and rarely, and might be used across multiple deployment overlays. eg it's not run by the test harness like the deploy script is.

I don't know if we can plumb the noauth overlay selection through to here anyway.

Definitely the documentation around this can be improved.

[saikat-royc]

@mattcary I was thinking more for a first time setup on GCE cluster, where we would like to use the noauth style ADC. The current script, will detect there is no existing SA, and set CREATE_SA=true, and proceed with SA creation and key creation(we could take a new flag SKIP_SA_KEY_CREATE which is false by default). Thoughts?

[mattcary]

Yeah, that makes sense. I think we should make the noauth method the default one and nudge everyone towards a streamlined setup. So maybe have SA_KEY_CREATE = false by default

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[mattcary]

/lifecycle frozen We should add the SKIP_SA_GENERATION as you suggest. We can do this in the upcoming fixit.

…

On Tue, Feb 2, 2021 at 10:53 AM fejta-bot ***@***.***> wrote: Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Send feedback to sig-testing, kubernetes/test-infra and/or fejta <https://github.com/fejta>. /lifecycle stale — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#639 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJCBAFJ4BN2WTPJZJNSB2TS5BC23ANCNFSM4TBN6JMQ> .