Skip to content

Increase operation timeouts for csi sidecars #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saikat-royc opened this issue Jul 1, 2020 · 1 comment · Fixed by #542
Closed

Increase operation timeouts for csi sidecars #541

saikat-royc opened this issue Jul 1, 2020 · 1 comment · Fixed by #542
Assignees

Comments

@saikat-royc
Copy link
Member

While fixing #526, observed that Create Volume from a snapshot datasource takes time to get provisioned.

following behavior in provisioning seen in GCE PD CSI driver:
there are 2 cases for a CreateVolume call (https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/pkg/gce-pd-csi-driver/controller.go#L88):

disk already found. we check for ready status and return error if not ready.
no existing disk found, so we trigger an insert op and wait for the op to complete (timeout for the poll operation for insert op is 5 mins). The wait for op gets cancelled due to a short deadline of set in the context (10 secs), by the client csi-provisioner sidecar.
By increasing the timeout from 10 secs to the order of minutes, we significantly reduce round-trips os retries due to diskNotReady error.

Provisioner and Attacher sidecars timeout need to be increased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant