Skip to content

PD CSI Driver CreateVolume should wait for Disk to reach READY status before returning success #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
saikat-royc opened this issue Jun 11, 2020 · 1 comment · Fixed by #527
Closed

PD CSI Driver CreateVolume should wait for Disk to reach READY status before returning success #526

saikat-royc opened this issue Jun 11, 2020 · 1 comment · Fixed by #527

Comments

@saikat-royc
Copy link
Member

For CreateVolume,

  1. if an existing disk is found a success is directly returned without checking ready status:
    https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/pkg/gce-pd-csi-driver/controller.go#L140

  2. Similarly at the end of the operation we should check for ready status.
    https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/pkg/gce-cloud-provider/compute/gce-compute.go#L304
    https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/pkg/gce-cloud-provider/compute/gce-compute.go#L323
@saikat-royc
Copy link
Member Author

/cc @msau42 @mattcary

@saikat-royc saikat-royc changed the title CreateVolume should wait for Disk to reach READY status before returning success PD CSI Driver CreateVolume should wait for Disk to reach READY status before returning success Jun 11, 2020
This was referenced Jun 12, 2020
Merged
Closed
@saikat-royc saikat-royc mentioned this issue Jun 18, 2020
Closed
@saikat-royc saikat-royc mentioned this issue Jul 1, 2020
Closed
This was referenced Sep 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return success in CreateVolume when disk is READY saikat-royc/gcp-compute-persistent-disk-csi-driver
1 participant
@saikat-royc