Skip to content

Node DaemonSet in Kubernetes Deployment Should Not Run On Master #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidz627 opened this issue Jul 2, 2018 · 6 comments
Open
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@davidz627
Copy link
Contributor

Currently the Daemonset constantly attempts to create the pod on master and fails because of resource limits. We should stop scheduling on master so that it does not continually loop attempted creation.

This is high priority as we have seen the daemonset pod kick off the api server from the master putting the whole cluster in a bad state.

@davidz627 davidz627 added the kind/bug Categorizes issue or PR as related to a bug. label Jul 2, 2018
@davidz627 davidz627 added this to the Alpha milestone Jul 2, 2018
@msau42
Copy link
Contributor

msau42 commented Jul 2, 2018

Looking at my master node,

Taints:             <none>
Unschedulable:      true

My master daemonset pod:

Tolerations:     node.kubernetes.io/disk-pressure:NoSchedule
                 node.kubernetes.io/memory-pressure:NoSchedule
                 node.kubernetes.io/not-ready:NoExecute
                 node.kubernetes.io/unreachable:NoExecute

@janetkuo, do you know how to prevent daemonset pods from being scheduled on the master?

@msau42
Copy link
Contributor

msau42 commented Jul 2, 2018

(this is gce, not gke)

@davidz627
Copy link
Contributor Author

From https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/:

The unschedulable field of a node is not respected by the DaemonSet controller.

Looks like taints are respected though, but my thought is tainting the master node could have unwanted side-effects

@msau42
Copy link
Contributor

msau42 commented Jul 3, 2018

I don't know if there are any such addons that want to run on all nodes, including the master.

@davidz627 davidz627 modified the milestones: Alpha, GA Oct 4, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2019
@msau42
Copy link
Contributor

msau42 commented Apr 30, 2019

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 30, 2019
@davidz627 davidz627 modified the milestones: GA, Post-GA Sep 18, 2019
tsmetana pushed a commit to tsmetana/gcp-compute-persistent-disk-csi-driver that referenced this issue Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants