Pre-stop hook to delete registration socket isn't working

[verult]

Node-driver-registrar moved to distroless, so shelling no longer works. Alternative solution is being discussed at the node-driver-registrar level here: kubernetes-csi/node-driver-registrar#21 (comment)

[davidz627]

will be fixed in node driver registrar by reconciling the socket and also deleting it on sigterm

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[verult]

Issue tracking socket reconciliation:
kubernetes-csi/node-driver-registrar#57

[verult]

/remove-lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[msau42]

/lifecycle frozen

[jsafrane]

I'm removing preStop hook from csi-driver-hostpath in kubernetes-csi/csi-driver-host-path#176. It can't work and nobody is adding shell to node-driver-registrar. It would be nice if it was removed from GCE PD manifests too, so kubernetes tests logs are cleaner.

Effort to add signal handling to node-driver-registrar is IMO orthogonal.

[saad-ali]

preStop hook was removed in #520
Whenever kubernetes-csi/node-driver-registrar#21 or kubernetes-csi/node-driver-registrar#57 are tracking the new fix.

[k8s-ci-robot]

@saad-ali: Closing this issue.

In response to this:

preStop hook was removed in #520
Whenever kubernetes-csi/node-driver-registrar#21 or kubernetes-csi/node-driver-registrar#57 are tracking the new fix.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.