Skip to content

Add Flag to Driver for Controller or Node Mode #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidz627 opened this issue Jun 28, 2018 · 9 comments · Fixed by #702
Closed

Add Flag to Driver for Controller or Node Mode #34

davidz627 opened this issue Jun 28, 2018 · 9 comments · Fixed by #702
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@davidz627
Copy link
Contributor

Add a flag --node to turn on the node server, --controller to turn on the controller server. They should both default to false.

Currently every driver runs all the node, controller, and identity servers by default.

@davidz627 davidz627 added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 28, 2018
@davidz627 davidz627 added this to the GA milestone Jun 28, 2018
@msau42
Copy link
Contributor

msau42 commented Jun 28, 2018

Could potentially also look into building them into separate binaries too

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2019
@davidz627
Copy link
Contributor Author

/remove-lifecycle stale
/add-lifecycle frozen

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2019
@davidz627
Copy link
Contributor Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 24, 2019
@davidz627 davidz627 modified the milestones: GA, Post-GA Sep 18, 2019
@Jiawei0227
Copy link
Contributor

#449 fixed it.
/close

@k8s-ci-robot
Copy link
Contributor

@Jiawei0227: Closing this issue.

In response to this:

#449 fixed it.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mattcary
Copy link
Contributor

mattcary commented Feb 5, 2021

/open

Shouldn't we actually use this flag as well to not run the controller on the node pods?

@Jiawei0227
Copy link
Contributor

Yep. I thought this issue is about adding the flag. We can use the issue to track changing the deployment for sure.

@mattcary
Copy link
Contributor

mattcary commented Feb 5, 2021 via email

dobsonj pushed a commit to dobsonj/gcp-compute-persistent-disk-csi-driver that referenced this issue Oct 17, 2023
OCPBUGS-11000: UPSTREAM: 988: Simplify node backoff logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants