Skip to content

Controller unit tests should mock cloud provider better and check for expected calls #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
davidz627 opened this issue Dec 21, 2018 · 2 comments
Open

Controller unit tests should mock cloud provider better and check for expected calls #216

davidz627 opened this issue Dec 21, 2018 · 2 comments
Labels
kind/test Categorizes issue or PR as related to testing lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
Post-GA

Comments

@davidz627
Copy link
Contributor

I've seen other test frameworks do things like cloud.EXPECT(function call(ARGS)), would be nice as an extra verification in unit tests.
@davidz627 davidz627 added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/test Categorizes issue or PR as related to testing labels Dec 21, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2019
@davidz627
Copy link
Contributor Author

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 29, 2019
@davidz627 davidz627 added this to the Post-GA milestone Sep 18, 2019
FZhg added a commit to FZhg/gcp-compute-persistent-disk-csi-driver that referenced this issue Sep 20, 2023
@FZhg
Squashed 'release-tools/' changes from 78c0fb71..984feece
3b4f7c2 
984feece Merge pull request kubernetes-sigs#234 from siddhikhapare/csi-tools
1f7e6059 fixed broken links of testgrid dashboard
de2fba88 Merge pull request kubernetes-sigs#233 from andyzhangx/andyzhangx-patch-1
cee895e1 remove windows 20H2 build since it's EOL long time ago
670bb0ef Merge pull request kubernetes-sigs#229 from marosset/fix-codespell-errors
35d5e783 Merge pull request kubernetes-sigs#219 from yashsingh74/update-registry
63473cc9 Merge pull request kubernetes-sigs#231 from coulof/bump-go-version-1.20.5
29a5c76c Merge pull request kubernetes-sigs#228 from mowangdk/chore/adopt_kubernetes_recommand_labels
8dd28211 Update cloudbuild image with go 1.20.5
1df23dba Merge pull request kubernetes-sigs#230 from msau42/prow
1f92b7e7 Add ginkgo timeout to e2e tests to help catch any stuck tests
2b8b80ea fixing some codespell errors
c10b6780 Merge pull request kubernetes-sigs#227 from coulof/check-sidecar-supported-versions
72984ec0 chore: adopt kubernetes recommand label
b0555351 Header
bd0a10b6 typo
c39d73c3 Add comments
f6491af0 Script to verify EOL sidecar version
4133d1df Merge pull request kubernetes-sigs#226 from msau42/cloudbuild
8d519d23 Pin buildkit to v0.10.6 to workaround v0.11 bug with docker manifest
6e04a030 Merge pull request kubernetes-sigs#224 from msau42/cloudbuild
26fdfffd Update cloudbuild image
6613c398 Merge pull request kubernetes-sigs#223 from sunnylovestiramisu/update
0e7ae993 Update k8s image repo url
77e47cce Merge pull request kubernetes-sigs#222 from xinydev/fix-dep-version
155854b0 Fix dep version mismatch
8f839056 Merge pull request kubernetes-sigs#221 from sunnylovestiramisu/go-update
1d3f94dd Update go version to 1.20 to match k/k v1.27
e322ce5e Merge pull request kubernetes-sigs#220 from andyzhangx/fix-golint-error
b74a5120 test: fix golint error
901bcb5a Update registry k8s.gcr.io -> registry.k8s.io
aa61bfd0 Merge pull request kubernetes-sigs#218 from xing-yang/update_csi_driver
7563d196 Update CSI_PROW_DRIVER_VERSION to v1.11.0
a2171bef Merge pull request kubernetes-sigs#216 from msau42/process
cb987826 Merge pull request kubernetes-sigs#217 from msau42/owners
a11216e4 add new reviewers and remove inactive reviewers
dd986754 Add step for checking builds
b66c0824 Merge pull request kubernetes-sigs#214 from pohly/junit-fixes
b9b6763b filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit
d4277839 filter-junit.go: preserve system error log
38e11468 prow.sh: publish individual JUnit files as separate artifacts

git-subtree-dir: release-tools
git-subtree-split: 984feece4bafac3aad74deeed76a500a0c485fb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/test Categorizes issue or PR as related to testing lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
Post-GA
Development

No branches or pull requests
3 participants
@davidz627 @k8s-ci-robot @fejta-bot