N4 instances have wrong attach limit

[jsafrane]

N4 instances can use only hyperdisk-balanced disks and they have a different attach limit than regular "persistent disks": https://cloud.google.com/compute/docs/general-purpose-machines#disk_and_capacity_limits_2

The CSI driver should report 20 disks per n4-standard-2, now it reports 127.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[jsafrane]

/remove-lifecycle rotten

[sunnylovestiramisu]

This is fixed in master

/close

[k8s-ci-robot]

@sunnylovestiramisu: Closing this issue.

In response to this:

This is fixed in master

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jsafrane]

/reopen

It's much better, just off-by-one :-).
The driver reports 16 attachments on n4-standard-4, but it forgets the root disk. Only 15 Pods with one volume each can run on the machine, the 16th one shows:

AttachVolume.Attach failed for volume "pvc-c1673c2a-7749-4b9b-b270-3544d9b04cef" : rpc error: code = InvalidArgument desc = Failed to Attach: failed when waiting for zonal op: rpc error: code = InvalidArgument desc = operation operation-1744802898292-632e394f4ad33-7301bb9b-ce176f79 failed (UNSUPPORTED_OPERATION): Maximum hyperdisk-balanced disks count should be less than or equal to [16], Requested : [17]

The driver reports 127 attachments for pd-disks, so it should report 15 for hyperdisks.

[k8s-ci-robot]

@jsafrane: Reopened this issue.

In response to this:

/reopen

It's much better, just off-by-one :-).
The driver reports 16 attachments on n4-standard-4, but it forgets the root disk. Only 15 Pods with one volume each can run on the machine, 16th shows:

AttachVolume.Attach failed for volume "pvc-c1673c2a-7749-4b9b-b270-3544d9b04cef" : rpc error: code = InvalidArgument desc = Failed to Attach: failed when waiting for zonal op: rpc error: code = InvalidArgument desc = operation operation-1744802898292-632e394f4ad33-7301bb9b-ce176f79 failed (UNSUPPORTED_OPERATION): Maximum hyperdisk-balanced disks count should be less than or equal to [16], Requested : [17]

The driver reports 127 attachments for pd-disks, so it should report 15 for hyperdisks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jsafrane]

Proposing a fix in #2057