Skip to content

Commit c6d428f

Browse files
committed
add disk name to logging
1 parent 747c952 commit c6d428f

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

pkg/gce-cloud-provider/compute/gce-compute.go

+10-8
Original file line numberDiff line numberDiff line change
@@ -415,13 +415,14 @@ func (cloud *CloudProvider) insertRegionalDisk(
415415
insertOp, err = cloud.betaService.RegionDisks.Insert(project, volKey.Region, betaDiskToCreate).Context(ctx).Do()
416416
if insertOp != nil {
417417
opName = insertOp.Name
418+
klog.V(5).Infof("InsertDisk operation %s for disk %s", opName, betaDiskToCreate.Name)
418419
}
419420
} else {
420421
var insertOp *computev1.Operation
421422
insertOp, err = cloud.service.RegionDisks.Insert(project, volKey.Region, diskToCreate).Context(ctx).Do()
422423
if insertOp != nil {
423424
opName = insertOp.Name
424-
klog.V(5).Infof("InsertDisk operation %s", opName)
425+
klog.V(5).Infof("InsertDisk operation %s for disk %s", opName, diskToCreate.Name)
425426
}
426427
}
427428
if err != nil {
@@ -510,13 +511,14 @@ func (cloud *CloudProvider) insertZonalDisk(
510511
insertOp, err = cloud.betaService.Disks.Insert(project, volKey.Zone, betaDiskToCreate).Context(ctx).Do()
511512
if insertOp != nil {
512513
opName = insertOp.Name
514+
klog.V(5).Infof("InsertDisk operation %s for disk %s", opName, betaDiskToCreate.Name)
513515
}
514516
} else {
515517
var insertOp *computev1.Operation
516518
insertOp, err = cloud.service.Disks.Insert(project, volKey.Zone, diskToCreate).Context(ctx).Do()
517519
if insertOp != nil {
518520
opName = insertOp.Name
519-
klog.V(5).Infof("InsertDisk operation %s", opName)
521+
klog.V(5).Infof("InsertDisk operation %s for disk %s", opName, diskToCreate.Name)
520522
}
521523
}
522524

@@ -577,7 +579,7 @@ func (cloud *CloudProvider) DeleteDisk(ctx context.Context, project string, volK
577579
func (cloud *CloudProvider) deleteZonalDisk(ctx context.Context, project, zone, name string) error {
578580
op, err := cloud.service.Disks.Delete(project, zone, name).Context(ctx).Do()
579581
if op != nil {
580-
klog.V(5).Infof("DeleteDisk operation %s", op.Name)
582+
klog.V(5).Infof("DeleteDisk operation %s for disk %s", op.Name, name)
581583
}
582584
if err != nil {
583585
if IsGCEError(err, "notFound") {
@@ -596,7 +598,7 @@ func (cloud *CloudProvider) deleteZonalDisk(ctx context.Context, project, zone,
596598
func (cloud *CloudProvider) deleteRegionalDisk(ctx context.Context, project, region, name string) error {
597599
op, err := cloud.service.RegionDisks.Delete(project, region, name).Context(ctx).Do()
598600
if op != nil {
599-
klog.V(5).Infof("DeleteDisk operation %s", op.Name)
601+
klog.V(5).Infof("DeleteDisk operation %s for disk %s", op.Name, name)
600602
}
601603
if err != nil {
602604
if IsGCEError(err, "notFound") {
@@ -630,7 +632,7 @@ func (cloud *CloudProvider) AttachDisk(ctx context.Context, project string, volK
630632

631633
op, err := cloud.service.Instances.AttachDisk(project, instanceZone, instanceName, attachedDiskV1).Context(ctx).Do()
632634
if op != nil {
633-
klog.V(5).Infof("AttachDisk operation %s", op.Name)
635+
klog.V(5).Infof("AttachDisk operation %s for disk %s", op.Name, attachedDiskV1.DeviceName)
634636
}
635637
if err != nil {
636638
return fmt.Errorf("failed cloud service attach disk call: %v", err)
@@ -646,7 +648,7 @@ func (cloud *CloudProvider) DetachDisk(ctx context.Context, project, deviceName,
646648
klog.V(5).Infof("Detaching disk %v from %v", deviceName, instanceName)
647649
op, err := cloud.service.Instances.DetachDisk(project, instanceZone, instanceName, deviceName).Context(ctx).Do()
648650
if op != nil {
649-
klog.V(5).Infof("DetachDisk operation %s", op.Name)
651+
klog.V(5).Infof("DetachDisk operation %s for disk %s", op.Name, deviceName)
650652
}
651653
if err != nil {
652654
return err
@@ -861,7 +863,7 @@ func (cloud *CloudProvider) resizeZonalDisk(ctx context.Context, project string,
861863
}
862864
op, err := cloud.service.Disks.Resize(project, volKey.Zone, volKey.Name, resizeReq).Context(ctx).Do()
863865
if op != nil {
864-
klog.V(5).Infof("ResizeDisk operation %s", op.Name)
866+
klog.V(5).Infof("ResizeDisk operation %s for disk %s", op.Name, volKey.Name)
865867
}
866868
if err != nil {
867869
return -1, fmt.Errorf("failed to resize zonal volume %v: %v", volKey.String(), err)
@@ -882,7 +884,7 @@ func (cloud *CloudProvider) resizeRegionalDisk(ctx context.Context, project stri
882884

883885
op, err := cloud.service.RegionDisks.Resize(project, volKey.Region, volKey.Name, resizeReq).Context(ctx).Do()
884886
if op != nil {
885-
klog.V(5).Infof("ResizeDisk operation %s", op.Name)
887+
klog.V(5).Infof("ResizeDisk operation %s for disk %s", op.Name, volKey.Name)
886888
}
887889
if err != nil {
888890
return -1, fmt.Errorf("failed to resize regional volume %v: %v", volKey.String(), err)

0 commit comments

Comments
 (0)