Skip to content

Commit 747c952

Browse files
committed
log operation id for attach and detach
1 parent 41bba8a commit 747c952

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

pkg/gce-cloud-provider/compute/gce-compute.go

+20
Original file line numberDiff line numberDiff line change
@@ -421,6 +421,7 @@ func (cloud *CloudProvider) insertRegionalDisk(
421421
insertOp, err = cloud.service.RegionDisks.Insert(project, volKey.Region, diskToCreate).Context(ctx).Do()
422422
if insertOp != nil {
423423
opName = insertOp.Name
424+
klog.V(5).Infof("InsertDisk operation %s", opName)
424425
}
425426
}
426427
if err != nil {
@@ -515,6 +516,7 @@ func (cloud *CloudProvider) insertZonalDisk(
515516
insertOp, err = cloud.service.Disks.Insert(project, volKey.Zone, diskToCreate).Context(ctx).Do()
516517
if insertOp != nil {
517518
opName = insertOp.Name
519+
klog.V(5).Infof("InsertDisk operation %s", opName)
518520
}
519521
}
520522

@@ -574,6 +576,9 @@ func (cloud *CloudProvider) DeleteDisk(ctx context.Context, project string, volK
574576

575577
func (cloud *CloudProvider) deleteZonalDisk(ctx context.Context, project, zone, name string) error {
576578
op, err := cloud.service.Disks.Delete(project, zone, name).Context(ctx).Do()
579+
if op != nil {
580+
klog.V(5).Infof("DeleteDisk operation %s", op.Name)
581+
}
577582
if err != nil {
578583
if IsGCEError(err, "notFound") {
579584
// Already deleted
@@ -590,6 +595,9 @@ func (cloud *CloudProvider) deleteZonalDisk(ctx context.Context, project, zone,
590595

591596
func (cloud *CloudProvider) deleteRegionalDisk(ctx context.Context, project, region, name string) error {
592597
op, err := cloud.service.RegionDisks.Delete(project, region, name).Context(ctx).Do()
598+
if op != nil {
599+
klog.V(5).Infof("DeleteDisk operation %s", op.Name)
600+
}
593601
if err != nil {
594602
if IsGCEError(err, "notFound") {
595603
// Already deleted
@@ -621,6 +629,9 @@ func (cloud *CloudProvider) AttachDisk(ctx context.Context, project string, volK
621629
}
622630

623631
op, err := cloud.service.Instances.AttachDisk(project, instanceZone, instanceName, attachedDiskV1).Context(ctx).Do()
632+
if op != nil {
633+
klog.V(5).Infof("AttachDisk operation %s", op.Name)
634+
}
624635
if err != nil {
625636
return fmt.Errorf("failed cloud service attach disk call: %v", err)
626637
}
@@ -634,6 +645,9 @@ func (cloud *CloudProvider) AttachDisk(ctx context.Context, project string, volK
634645
func (cloud *CloudProvider) DetachDisk(ctx context.Context, project, deviceName, instanceZone, instanceName string) error {
635646
klog.V(5).Infof("Detaching disk %v from %v", deviceName, instanceName)
636647
op, err := cloud.service.Instances.DetachDisk(project, instanceZone, instanceName, deviceName).Context(ctx).Do()
648+
if op != nil {
649+
klog.V(5).Infof("DetachDisk operation %s", op.Name)
650+
}
637651
if err != nil {
638652
return err
639653
}
@@ -846,6 +860,9 @@ func (cloud *CloudProvider) resizeZonalDisk(ctx context.Context, project string,
846860
SizeGb: requestGb,
847861
}
848862
op, err := cloud.service.Disks.Resize(project, volKey.Zone, volKey.Name, resizeReq).Context(ctx).Do()
863+
if op != nil {
864+
klog.V(5).Infof("ResizeDisk operation %s", op.Name)
865+
}
849866
if err != nil {
850867
return -1, fmt.Errorf("failed to resize zonal volume %v: %v", volKey.String(), err)
851868
}
@@ -864,6 +881,9 @@ func (cloud *CloudProvider) resizeRegionalDisk(ctx context.Context, project stri
864881
}
865882

866883
op, err := cloud.service.RegionDisks.Resize(project, volKey.Region, volKey.Name, resizeReq).Context(ctx).Do()
884+
if op != nil {
885+
klog.V(5).Infof("ResizeDisk operation %s", op.Name)
886+
}
867887
if err != nil {
868888
return -1, fmt.Errorf("failed to resize regional volume %v: %v", volKey.String(), err)
869889
}

0 commit comments

Comments
 (0)