Skip to content

Commit 765dc41

Browse files
committed
always set gcflags in Makefile
1 parent 5c2696b commit 765dc41

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Dockerfile.debug

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ WORKDIR /go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver
1717
ADD . .
1818

1919
RUN CGO_ENABLED=0 go get -ldflags "-s -w -extldflags '-static'" github.com/go-delve/delve/cmd/dlv
20-
RUN GCE_PD_CSI_DEBUG=1 make
20+
RUN GCE_PD_CSI_DEBUG=1 make gce-pd-driver
2121

2222
# MAD HACKS: Build a version first so we can take the scsi_id bin and put it somewhere else in our real build
2323
FROM k8s.gcr.io/build-image/debian-base-amd64:v2.1.3 as base

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ endif
2323

2424
GCFLAGS=""
2525
ifdef GCE_PD_CSI_DEBUG
26-
GCFLAGS=-gcflags="all=-N -L"
26+
GCFLAGS="all=-N -l"
2727
endif
2828

2929
STAGINGIMAGE=${GCE_PD_CSI_STAGING_IMAGE}
@@ -44,7 +44,7 @@ WINDOWS_BASE_IMAGES=$(BASE_IMAGE_LTSC2019) $(BASE_IMAGE_1909) $(BASE_IMAGE_2004)
4444
all: gce-pd-driver gce-pd-driver-windows
4545
gce-pd-driver:
4646
mkdir -p bin
47-
go build -mod=vendor $(GCFLAGS) -ldflags "-X main.version=$(STAGINGVERSION)" -o bin/${DRIVERBINARY} ./cmd/gce-pd-csi-driver/
47+
go build -mod=vendor -gcflags=$(GCFLAGS) -ldflags "-X main.version=$(STAGINGVERSION)" -o bin/${DRIVERBINARY} ./cmd/gce-pd-csi-driver/
4848

4949
gce-pd-driver-windows:
5050
mkdir -p bin

0 commit comments

Comments
 (0)