use GCFLAGS with envvar

Author: mauriciopoppe

Diff for: Dockerfile.debug

@@ -1,4 +1,4 @@
-# Copyright 2018 The Kubernetes Authors.
+# Copyright 2021 The Kubernetes Authors.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -25,7 +25,8 @@ RUN clean-install udev
 
 # Start from Kubernetes Debian base
 FROM k8s.gcr.io/build-image/debian-base-amd64:v2.1.3
-# Copy source code too?
+
+# Copy source code too to correlate the binary and the breakpoints
 WORKDIR /go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver
 ADD . .
 
@@ -35,4 +36,7 @@ COPY --from=builder /go/bin/dlv /go/bin/dlv
 RUN clean-install util-linux e2fsprogs mount ca-certificates udev xfsprogs
 COPY --from=base /lib/udev/scsi_id /lib/udev_containerized/scsi_id
 
+# PDCSI driver isn't copied to / because of delve not being able to correlate
+# the binary and the source code, instead just run the binary where it was
+# compiled, the overlay noauth-dev calls this binary
 ENTRYPOINT ["/go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/bin/gce-pd-csi-driver"]

Diff for: Makefile

@@ -44,7 +44,7 @@ WINDOWS_BASE_IMAGES=$(BASE_IMAGE_LTSC2019) $(BASE_IMAGE_1909) $(BASE_IMAGE_2004)
 all: gce-pd-driver gce-pd-driver-windows
 gce-pd-driver:
 	mkdir -p bin
-	go build -mod=vendor -gcflags="all=-N -l" -ldflags "-X main.version=$(STAGINGVERSION)" -o bin/${DRIVERBINARY} ./cmd/gce-pd-csi-driver/
+	go build -mod=vendor $(GCFLAGS) -ldflags "-X main.version=$(STAGINGVERSION)" -o bin/${DRIVERBINARY} ./cmd/gce-pd-csi-driver/
 
 gce-pd-driver-windows:
 	mkdir -p bin

Diff for: deploy/kubernetes/overlays/noauth-dev/kustomization.yaml

@@ -10,7 +10,7 @@ patchesStrategicMerge:
 - controller-overlay.yaml
 namespace: gce-pd-csi-driver
 # To change the dev image, add something like the following.
-images:
-- name: gke.gcr.io/gcp-compute-persistent-disk-csi-driver
-  newName: gcr.io/mauriciopoppe-gke-dev/gcp-compute-persistent-disk-csi-driver
-  newTag: latest
+# images:
+# - name: gke.gcr.io/gcp-compute-persistent-disk-csi-driver
+#   newName: gcr.io/mauriciopoppe-gke-dev/gcp-compute-persistent-disk-csi-driver
+#   newTag: latest