remove SchedulingContext, flatten scheduler interfaces #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nir Rozenbaum <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
irar2
pushed a commit
to irar2/gateway-api-inference-extension
that referenced
this pull request
Jun 3, 2025
…gs#889) Signed-off-by: Nir Rozenbaum <[email protected]>
shmuelk
pushed a commit
to shmuelk/gateway-api-inference-extension
that referenced
this pull request
Jun 3, 2025
…gs#889) Signed-off-by: Nir Rozenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the iterative progress of scheduler redesign.
It completely removes the use of SchedulingContext. instead all interfaces were updated with the arguments (instead of wrapping everything inside scheduling context and pass that as one arg). This is aligned with the discussions on scheduler design choices made on #845.
one leftover that is still here is the LLMRequest and LLMResponse structs (should replace with a map[string]any to store arbitrary data), that should be replaced as we continue to make progress. this PR doesn't include getting rid of those and it will be handled in follow up PRs.
additionally, PostCycle has to be removed (after cleaned from Prefix plugin) and PostResponse should be extracted to request control layer. all of this is not part of this PR, as we aim to do the transition iteratively and not one huge PR.
cc: @ahg-g