Healthcheck fix #788
Merged
Healthcheck fix #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
rlakhtakia
pushed a commit
to rlakhtakia/gateway-api-inference-extension
that referenced
this pull request
May 13, 2025
* Revert "fix: add required List() method to epp health server" This reverts commit a305927. * Revert "fix: add required List() method to bbr health server" This reverts commit 43da9fa. * Revert "fix: check for distinct gRPC services in epp health check" This reverts commit 2f72a8a. * Revert "fix: check for distinct gRPC services in bbr health check" This reverts commit 4bf03ad. * Revert "chore: update google.golang.org/grpc dep from v1.71.1 to v1.72.0" This reverts commit a6c3ede. * Revert "chore: add go's default main output binary to .gitignore" This reverts commit db30475. * go mod tidy output
nayihz
pushed a commit
to nayihz/gateway-api-inference-extension
that referenced
this pull request
May 14, 2025
* Revert "fix: add required List() method to epp health server" This reverts commit a305927. * Revert "fix: add required List() method to bbr health server" This reverts commit 43da9fa. * Revert "fix: check for distinct gRPC services in epp health check" This reverts commit 2f72a8a. * Revert "fix: check for distinct gRPC services in bbr health check" This reverts commit 4bf03ad. * Revert "chore: update google.golang.org/grpc dep from v1.71.1 to v1.72.0" This reverts commit a6c3ede. * Revert "chore: add go's default main output binary to .gitignore" This reverts commit db30475. * go mod tidy output
kaushikmitr
pushed a commit
to kaushikmitr/llm-instance-gateway
that referenced
this pull request
May 15, 2025
* Revert "fix: add required List() method to epp health server" This reverts commit a305927. * Revert "fix: add required List() method to bbr health server" This reverts commit 43da9fa. * Revert "fix: check for distinct gRPC services in epp health check" This reverts commit 2f72a8a. * Revert "fix: check for distinct gRPC services in bbr health check" This reverts commit 4bf03ad. * Revert "chore: update google.golang.org/grpc dep from v1.71.1 to v1.72.0" This reverts commit a6c3ede. * Revert "chore: add go's default main output binary to .gitignore" This reverts commit db30475. * go mod tidy output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reversion of #777 which
Fixes: #786
Validated that main had the issue seen in #786, and this rollback fixes that issue