Skip to content

Add prefix cache aware scheduling #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions cmd/epp/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import (
"k8s.io/client-go/rest"
"k8s.io/component-base/metrics/legacyregistry"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/metrics/filters"
Expand All @@ -43,7 +44,13 @@ import (
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/metrics"
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/metrics/collectors"
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling"
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/plugins"
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/plugins/filter"
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/plugins/picker"
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/plugins/prefix"
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/plugins/scorer"
runserver "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/server"
envutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/env"
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/logging"
)

Expand Down Expand Up @@ -107,8 +114,22 @@ var (
"Prometheus metric for the LoRA info metrics (must be in vLLM label format).")

setupLog = ctrl.Log.WithName("setup")

// Environment variables
schedulerV2 = envutil.GetEnvString("EXPERIMENTAL_USE_SCHEDULER_V2", "false", setupLog)
prefixCacheScheduling = envutil.GetEnvString("ENABLE_PREFIX_CACHE_SCHEDULING", "false", setupLog)
)

func loadPrefixCacheConfig() prefix.Config {
baseLogger := log.Log.WithName("env-config")

return prefix.Config{
HashBlockSize: envutil.GetEnvInt("PREFIX_CACHE_HASH_BLOCK_SIZE", prefix.DefaultHashBlockSize, baseLogger),
MaxPrefixBlocksToMatch: envutil.GetEnvInt("PREFIX_CACHE_MAX_PREFIX_BLOCKS", prefix.DefaultMaxPrefixBlocks, baseLogger),
LRUIndexerCapacity: envutil.GetEnvInt("PREFIX_CACHE_LRU_CAPACITY", prefix.DefaultLRUIndexerCapacity, baseLogger),
}
}

func main() {
if err := run(); err != nil {
os.Exit(1)
Expand Down Expand Up @@ -172,6 +193,27 @@ func run() error {
datastore := datastore.NewDatastore(ctx, pmf)

scheduler := scheduling.NewScheduler(datastore)
if schedulerV2 == "true" {
queueScorerWeight := envutil.GetEnvInt("QUEUE_SCORE_WEIGHT", scorer.DefaultQueueScorerWeight, setupLog)
kvCacheScorerWeight := envutil.GetEnvInt("KV_CACHE_SCORE_WEIGHT", scorer.DefaultKVCacheScorerWeight, setupLog)
scorers := map[plugins.Scorer]int{
&scorer.QueueScorer{}: queueScorerWeight,
&scorer.KVCacheScorer{}: kvCacheScorerWeight,
}
schedConfigOpts := []scheduling.ConfigOption{}
if prefixCacheScheduling == "true" {
prefixScorerWeight := envutil.GetEnvInt("PREFIX_CACHE_SCORE_WEIGHT", prefix.DefaultScorerWeight, setupLog)
schedConfigOpts = append(schedConfigOpts, scheduling.AddPrefixPlugin(loadPrefixCacheConfig(), prefixScorerWeight))
}
schedulerConfig := scheduling.NewSchedulerConfig(
[]plugins.PreSchedule{},
[]plugins.Filter{filter.NewSheddableCapacityFilter()},
scorers,
picker.NewMaxScorePicker(),
[]plugins.PostSchedule{},
schedConfigOpts...)
scheduler = scheduling.NewSchedulerWithConfig(datastore, schedulerConfig)
}
serverRunner := &runserver.ExtProcServerRunner{
GrpcPort: *grpcPort,
DestinationEndpointHintMetadataNamespace: *destinationEndpointHintMetadataNamespace,
Expand Down
56 changes: 56 additions & 0 deletions pkg/epp/metrics/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,40 @@ var (
[]string{"plugin_type", "plugin_name"},
)

// Prefix indexer Metrics
PrefixCacheSize = compbasemetrics.NewGaugeVec(
&compbasemetrics.GaugeOpts{
Subsystem: InferenceExtension,
Name: "prefix_indexer_size",
Help: "Size of the prefix indexer.",
StabilityLevel: compbasemetrics.ALPHA,
},
[]string{},
)

PrefixCacheHitRatio = compbasemetrics.NewHistogramVec(
&compbasemetrics.HistogramOpts{
Subsystem: InferenceExtension,
Name: "prefix_indexer_hit_ratio",
Help: "Ratio of prefix length matched to total prefix length in the cache lookup.",
// Buckets from 0.0 to 1.0 in increments
Buckets: []float64{0.0, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1.0},
StabilityLevel: compbasemetrics.ALPHA,
},
[]string{},
)

PrefixCacheHitLength = compbasemetrics.NewHistogramVec(
&compbasemetrics.HistogramOpts{
Subsystem: InferenceExtension,
Name: "prefix_indexer_hit_bytes",
Help: "Length of the prefix match in number of bytes in the cache lookup.",
Buckets: []float64{0, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8192, 16384, 32768, 65536},
StabilityLevel: compbasemetrics.ALPHA,
},
[]string{},
)

// Info Metrics
InferenceExtensionInfo = compbasemetrics.NewGaugeVec(
&compbasemetrics.GaugeOpts{
Expand Down Expand Up @@ -244,6 +278,10 @@ func Register() {
legacyregistry.MustRegister(SchedulerE2ELatency)

legacyregistry.MustRegister(InferenceExtensionInfo)

legacyregistry.MustRegister(PrefixCacheSize)
legacyregistry.MustRegister(PrefixCacheHitRatio)
legacyregistry.MustRegister(PrefixCacheHitLength)
})
}

Expand Down Expand Up @@ -352,6 +390,24 @@ func RecordSchedulerE2ELatency(duration time.Duration) {
SchedulerE2ELatency.WithLabelValues().Observe(duration.Seconds())
}

// RecordPrefixCacheSize records the size of the prefix indexer in megabytes.
func RecordPrefixCacheSize(size int64) {
PrefixCacheSize.WithLabelValues().Set(float64(size))
}

// RecordPrefixCacheMatch records both the hit ratio and hit length for a prefix indexer match.
// matchedLength is the number of characters that matched, and totalLength is the total prefix length.
func RecordPrefixCacheMatch(matchedLength, totalLength int) {
// Record the hit length metric
PrefixCacheHitLength.WithLabelValues().Observe(float64(matchedLength))

// Record the hit ratio metric if totalLength is positive
if totalLength > 0 {
ratio := float64(matchedLength) / float64(totalLength)
PrefixCacheHitRatio.WithLabelValues().Observe(ratio)
}
}

func RecordInferenceExtensionInfo() {
if CommitSHA != "" {
InferenceExtensionInfo.WithLabelValues(CommitSHA).Set(1)
Expand Down
103 changes: 103 additions & 0 deletions pkg/epp/metrics/metrics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -664,3 +664,106 @@ func TestSchedulerE2ELatency(t *testing.T) {
})
}
}

func TestPrefixCacheMetrics(t *testing.T) {
const (
PrefixCacheSizeMetric = InferenceExtension + "_prefix_indexer_size"
PrefixCacheHitRatioMetric = InferenceExtension + "_prefix_indexer_hit_ratio"
PrefixCacheHitLengthMetric = InferenceExtension + "_prefix_indexer_hit_bytes"
)

type cacheMatchRecord struct {
matchedLength int
totalLength int
}

scenario := struct {
name string
cacheSizes []int64
cacheMatches []cacheMatchRecord
}{
name: "multiple cache metrics",
cacheSizes: []int64{1024, 2048, 4096},
cacheMatches: []cacheMatchRecord{
{
matchedLength: 5,
totalLength: 10,
},
{
matchedLength: 0,
totalLength: 10,
},
{
matchedLength: 10,
totalLength: 10,
},
{
matchedLength: 7,
totalLength: 10,
},
{
matchedLength: 64,
totalLength: 128,
},
{
matchedLength: 0,
totalLength: 128,
},
},
}

Register()
t.Run(scenario.name, func(t *testing.T) {
// Record cache size metrics
for _, size := range scenario.cacheSizes {
RecordPrefixCacheSize(size)
}

// Record cache match metrics (both hit ratio and hit length)
for _, match := range scenario.cacheMatches {
RecordPrefixCacheMatch(match.matchedLength, match.totalLength)
}

// Verify cache size metrics
wantCacheSizeMetrics, err := os.Open("testdata/prefix_indexer_size_metric")
defer func() {
if err := wantCacheSizeMetrics.Close(); err != nil {
t.Error(err)
}
}()
if err != nil {
t.Fatal(err)
}
if err := testutil.GatherAndCompare(legacyregistry.DefaultGatherer, wantCacheSizeMetrics, PrefixCacheSizeMetric); err != nil {
t.Error(err)
}

// Verify hit ratio metrics
wantHitRatioMetrics, err := os.Open("testdata/prefix_indexer_hit_ratio_metric")
defer func() {
if err := wantHitRatioMetrics.Close(); err != nil {
t.Error(err)
}
}()
if err != nil {
t.Fatal(err)
}
if err := testutil.GatherAndCompare(legacyregistry.DefaultGatherer, wantHitRatioMetrics, PrefixCacheHitRatioMetric); err != nil {
t.Error(err)
}

// Verify hit length metrics
wantHitLengthMetrics, err := os.Open("testdata/prefix_indexer_hit_bytes_metric")
defer func() {
if err := wantHitLengthMetrics.Close(); err != nil {
t.Error(err)
}
}()
if err != nil {
t.Fatal(err)
}
if err := testutil.GatherAndCompare(legacyregistry.DefaultGatherer, wantHitLengthMetrics, PrefixCacheHitLengthMetric); err != nil {
t.Error(err)
}
})
}
19 changes: 19 additions & 0 deletions pkg/epp/metrics/testdata/prefix_indexer_hit_bytes_metric
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# HELP inference_extension_prefix_indexer_hit_bytes [ALPHA] Length of the prefix match in number of bytes in the cache lookup.
# TYPE inference_extension_prefix_indexer_hit_bytes histogram
inference_extension_prefix_indexer_hit_bytes_bucket{le="0"} 2
inference_extension_prefix_indexer_hit_bytes_bucket{le="16"} 5
inference_extension_prefix_indexer_hit_bytes_bucket{le="32"} 5
inference_extension_prefix_indexer_hit_bytes_bucket{le="64"} 6
inference_extension_prefix_indexer_hit_bytes_bucket{le="128"} 6
inference_extension_prefix_indexer_hit_bytes_bucket{le="256"} 6
inference_extension_prefix_indexer_hit_bytes_bucket{le="512"} 6
inference_extension_prefix_indexer_hit_bytes_bucket{le="1024"} 6
inference_extension_prefix_indexer_hit_bytes_bucket{le="2048"} 6
inference_extension_prefix_indexer_hit_bytes_bucket{le="4096"} 6
inference_extension_prefix_indexer_hit_bytes_bucket{le="8192"} 6
inference_extension_prefix_indexer_hit_bytes_bucket{le="16384"} 6
inference_extension_prefix_indexer_hit_bytes_bucket{le="32768"} 6
inference_extension_prefix_indexer_hit_bytes_bucket{le="65536"} 6
inference_extension_prefix_indexer_hit_bytes_bucket{le="+Inf"} 6
inference_extension_prefix_indexer_hit_bytes_sum 86
inference_extension_prefix_indexer_hit_bytes_count 6
16 changes: 16 additions & 0 deletions pkg/epp/metrics/testdata/prefix_indexer_hit_ratio_metric
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# HELP inference_extension_prefix_indexer_hit_ratio [ALPHA] Ratio of prefix length matched to total prefix length in the cache lookup.
# TYPE inference_extension_prefix_indexer_hit_ratio histogram
inference_extension_prefix_indexer_hit_ratio_bucket{le="0"} 2
inference_extension_prefix_indexer_hit_ratio_bucket{le="0.1"} 2
inference_extension_prefix_indexer_hit_ratio_bucket{le="0.2"} 2
inference_extension_prefix_indexer_hit_ratio_bucket{le="0.3"} 2
inference_extension_prefix_indexer_hit_ratio_bucket{le="0.4"} 2
inference_extension_prefix_indexer_hit_ratio_bucket{le="0.5"} 4
inference_extension_prefix_indexer_hit_ratio_bucket{le="0.6"} 4
inference_extension_prefix_indexer_hit_ratio_bucket{le="0.7"} 5
inference_extension_prefix_indexer_hit_ratio_bucket{le="0.8"} 5
inference_extension_prefix_indexer_hit_ratio_bucket{le="0.9"} 5
inference_extension_prefix_indexer_hit_ratio_bucket{le="1"} 6
inference_extension_prefix_indexer_hit_ratio_bucket{le="+Inf"} 6
inference_extension_prefix_indexer_hit_ratio_sum 2.7
inference_extension_prefix_indexer_hit_ratio_count 6
3 changes: 3 additions & 0 deletions pkg/epp/metrics/testdata/prefix_indexer_size_metric
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# HELP inference_extension_prefix_indexer_size [ALPHA] Size of the prefix indexer.
# TYPE inference_extension_prefix_indexer_size gauge
inference_extension_prefix_indexer_size{} 4096
22 changes: 20 additions & 2 deletions pkg/epp/scheduling/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,23 @@ package scheduling

import (
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/plugins"
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/plugins/prefix"
)

// NewSchedulerConfig creates a new SchedulerConfig object with the given plugins.
func NewSchedulerConfig(preSchedulePlugins []plugins.PreSchedule, filters []plugins.Filter, scorers map[plugins.Scorer]int,
picker plugins.Picker, postSchedulePlugins []plugins.PostSchedule) *SchedulerConfig {
return &SchedulerConfig{
picker plugins.Picker, postSchedulePlugins []plugins.PostSchedule, opts ...ConfigOption) *SchedulerConfig {
config := &SchedulerConfig{
preSchedulePlugins: preSchedulePlugins,
filters: filters,
scorers: scorers,
picker: picker,
postSchedulePlugins: postSchedulePlugins,
}
for _, opt := range opts {
opt(config)
}
return config
}

// SchedulerConfig provides a configuration for the scheduler which influence routing decisions.
Expand All @@ -40,3 +45,16 @@ type SchedulerConfig struct {
picker plugins.Picker
postSchedulePlugins []plugins.PostSchedule
}

type ConfigOption func(*SchedulerConfig)

// TODO(https://github.com/kubernetes-sigs/gateway-api-inference-extension/issues/813): Replace this
// with a more generic way to add plugins.
func AddPrefixPlugin(prefixConfig prefix.Config, weight int) ConfigOption {
return func(cfg *SchedulerConfig) {
prefixPlugin := prefix.New(prefixConfig)
cfg.preSchedulePlugins = append(cfg.preSchedulePlugins, prefixPlugin)
cfg.postSchedulePlugins = append(cfg.postSchedulePlugins, prefixPlugin)
cfg.scorers[prefixPlugin] = weight
}
}
Loading