-
Notifications
You must be signed in to change notification settings - Fork 89
Docs: Adds Kgateway Cleanup to Quickstart #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Daneyon Hansen <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, wrote only one very minor comment.
I'm leaving it for your decision if you want to merge as is or address the comment.
/lgtm
/hold
|
||
=== "Kgateway" | ||
|
||
The following instructions assume you would like to cleanup ALL Kgateway resources that were created in this quickstart guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove this line which repeats the exact same words as the cleanup starting phrase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave the line as-is for now. It can be removed in the future if we feel it's an issue.
Adds Kgateway cleanup instructions to the quick start guide.