cleaning up inferencePool helm docs #665
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XS
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -34,7 +37,6 @@ The following table list the configurable parameters of the chart. | |||
|
|
|||
| | **Parameter Name** | **Description** | | |||
| |---------------------------------------------|------------------------------------------------------------------------------------------------------------------------| | |||
| | `inferencePool.name` | Name for the InferencePool, and endpoint picker deployment and service will be named as `{.Release.name}-epp`. | | |||
There was a problem hiding this comment.
Why remove the ability to set the InferencePool name?
There was a problem hiding this comment.
it is redundant, it is already the name of the "release".
|
/retest |
|
Will let a non-goog contributor stamp the LGTM on this one to remove potential biases |
|
note that this is not adding a new flag, this is already existing and released, the PR is just fixing inaccurate docs |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
No description provided.