Skip to content

Fix codegen #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix codegen #66

wants to merge 1 commit into from

Conversation

liu-cong
Copy link
Contributor

@liu-cong liu-cong commented Dec 4, 2024

When I ran make generate, I ran into error

./hack/.. script
../code-generator
./hack/update-codegen.sh: line 25: ../code-generator/kube_codegen.sh: No such file or directory

This fix was from the LWS repo: https://github.com/kubernetes-sigs/lws/blob/ed2b1f9848b6f38dfd553ccd838671933a343be5/hack/update-codegen.sh#L23

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kfswain December 4, 2024 18:54
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liu-cong
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Dec 5, 2024

is this still needed?

@liu-cong liu-cong closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants