Skip to content

remove deprecated v1alpha2.AddToScheme and use v1alpha2.Install instead #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/epp/controller/inferencemodel_reconciler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ func TestInferenceModelReconciler(t *testing.T) {
t.Run(test.name, func(t *testing.T) {
// Create a fake client with no InferenceModel objects.
scheme := runtime.NewScheme()
_ = v1alpha2.AddToScheme(scheme)
_ = v1alpha2.Install(scheme)
initObjs := []client.Object{}
if test.model != nil {
initObjs = append(initObjs, test.model)
Expand Down
2 changes: 1 addition & 1 deletion pkg/epp/controller/inferencepool_reconciler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func TestInferencePoolReconciler(t *testing.T) {
// Set up the scheme.
scheme := runtime.NewScheme()
_ = clientgoscheme.AddToScheme(scheme)
_ = v1alpha2.AddToScheme(scheme)
_ = v1alpha2.Install(scheme)

// Create a fake client with the pool and the pods.
initialObjects := []client.Object{pool1, pool2}
Expand Down
2 changes: 1 addition & 1 deletion pkg/epp/server/controller_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var scheme = runtime.NewScheme()

func init() {
utilruntime.Must(clientgoscheme.AddToScheme(scheme))
utilruntime.Must(v1alpha2.AddToScheme(scheme))
utilruntime.Must(v1alpha2.Install(scheme))
}

// DefaultManagerOptions returns the default options used to create the manager.
Expand Down
2 changes: 1 addition & 1 deletion test/integration/epp/hermetic_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1602,7 +1602,7 @@ func BeforeSuite() func() {
}

utilruntime.Must(clientgoscheme.AddToScheme(scheme))
utilruntime.Must(v1alpha2.AddToScheme(scheme))
utilruntime.Must(v1alpha2.Install(scheme))

k8sClient, err = k8sclient.New(cfg, k8sclient.Options{Scheme: scheme})
if err != nil {
Expand Down