generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 91
expose "Normalized Time Per Output Token" (NTPOT) metric #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dc8c0d7
add tpot to inference gateway exposed metrics
kaushikmitr 6eeab72
add tpot to inference gateway exposed metrics
kaushikmitr 5121c51
update logging and add ntpot logging to server.go
kaushikmitr f887ef6
update logging and add ntpot logging to server.go
kaushikmitr 9857871
fix lint error
kaushikmitr ba36b6e
change metric name from ntpot to normalized time per output token
kaushikmitr c51ada2
update metrics.md
kaushikmitr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -131,6 +131,21 @@ var ( | |||||
[]string{"model_name"}, | ||||||
) | ||||||
|
||||||
// NTPOT - Normalized Time Per Output Token | ||||||
latencyPerOutputToken = compbasemetrics.NewHistogramVec( | ||||||
&compbasemetrics.HistogramOpts{ | ||||||
Subsystem: InferenceModelComponent, | ||||||
Name: "ntpot_seconds", | ||||||
Help: "Inference model latency divided by number of output tokens in seconds for each model and target model.", | ||||||
// From few milliseconds per token to multiple seconds per token | ||||||
Buckets: []float64{ | ||||||
0.001, 0.002, 0.005, 0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1.0, 2.0, 5.0, 10.0, | ||||||
}, | ||||||
StabilityLevel: compbasemetrics.ALPHA, | ||||||
}, | ||||||
[]string{"model_name", "target_model_name"}, | ||||||
) | ||||||
|
||||||
// Inference Pool Metrics | ||||||
inferencePoolAvgKVCache = compbasemetrics.NewGaugeVec( | ||||||
&compbasemetrics.GaugeOpts{ | ||||||
|
@@ -176,6 +191,7 @@ func Register() { | |||||
legacyregistry.MustRegister(inputTokens) | ||||||
legacyregistry.MustRegister(outputTokens) | ||||||
legacyregistry.MustRegister(runningRequests) | ||||||
legacyregistry.MustRegister(latencyPerOutputToken) | ||||||
|
||||||
legacyregistry.MustRegister(inferencePoolAvgKVCache) | ||||||
legacyregistry.MustRegister(inferencePoolAvgQueueSize) | ||||||
|
@@ -231,6 +247,27 @@ func RecordOutputTokens(modelName, targetModelName string, size int) { | |||||
} | ||||||
} | ||||||
|
||||||
// RecordLatencyPerOutputToken (NTPOT) records the normalized time per output token. | ||||||
func RecordLatencyPerOutputToken(ctx context.Context, modelName, targetModelName string, received time.Time, complete time.Time, outputTokenCount int) bool { | ||||||
if !complete.After(received) { | ||||||
log.FromContext(ctx).V(logutil.DEFAULT).Error(nil, "Request latency values are invalid for NTPOT calculation", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
"modelName", modelName, "targetModelName", targetModelName, "completeTime", complete, "receivedTime", received) | ||||||
return false | ||||||
} | ||||||
|
||||||
if outputTokenCount <= 0 { | ||||||
log.FromContext(ctx).V(logutil.DEFAULT).Error(nil, "Output token count must be positive for NTPOT calculation", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
"modelName", modelName, "targetModelName", targetModelName, "outputTokenCount", outputTokenCount) | ||||||
return false | ||||||
} | ||||||
|
||||||
elapsedSeconds := complete.Sub(received).Seconds() | ||||||
secondsPerToken := elapsedSeconds / float64(outputTokenCount) | ||||||
|
||||||
latencyPerOutputToken.WithLabelValues(modelName, targetModelName).Observe(secondsPerToken) | ||||||
return true | ||||||
} | ||||||
|
||||||
// IncRunningRequests increases the current running requests. | ||||||
func IncRunningRequests(modelName string) { | ||||||
if modelName != "" { | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# HELP inference_model_ntpot_seconds [ALPHA] Inference model latency divided by number of output tokens in seconds for each model and target model. | ||
# TYPE inference_model_ntpot_seconds histogram | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="0.001"} 0 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="0.002"} 0 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="0.005"} 0 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="0.01"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="0.02"} 2 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="0.05"} 2 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="0.1"} 2 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="0.2"} 2 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="0.5"} 2 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="1.0"} 2 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="2.0"} 2 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="5.0"} 2 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="10.0"} 2 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t10", le="+Inf"} 2 | ||
inference_model_ntpot_seconds_sum{model_name="m10", target_model_name="t10"} 0.03 | ||
inference_model_ntpot_seconds_count{model_name="m10", target_model_name="t10"} 2 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="0.001"} 0 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="0.002"} 0 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="0.005"} 0 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="0.01"} 0 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="0.02"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="0.05"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="0.1"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="0.2"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="0.5"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="1.0"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="2.0"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="5.0"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="10.0"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m10", target_model_name="t11", le="+Inf"} 1 | ||
inference_model_ntpot_seconds_sum{model_name="m10", target_model_name="t11"} 0.02 | ||
inference_model_ntpot_seconds_count{model_name="m10", target_model_name="t11"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="0.001"} 0 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="0.002"} 0 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="0.005"} 0 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="0.01"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="0.02"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="0.05"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="0.1"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="0.2"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="0.5"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="1.0"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="2.0"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="5.0"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="10.0"} 1 | ||
inference_model_ntpot_seconds_bucket{model_name="m20", target_model_name="t20", le="+Inf"} 1 | ||
inference_model_ntpot_seconds_sum{model_name="m20", target_model_name="t20"} 0.006 | ||
inference_model_ntpot_seconds_count{model_name="m20", target_model_name="t20"} 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this to server.go as well?