Skip to content

Add support for configuring ports in BBR helm chart #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion config/charts/body-based-routing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,14 @@ The following table list the configurable parameters of the chart.
|---------------------------------------------|----------------------------------------------------------------------------------------------------|
| `bbr.name` | Name for the deployment and service. |
| `bbr.replicas` | Number of replicas for the deployment. Defaults to `1`. |
| `bbr.port` | Port serving ext_proc. Defaults to `9004`. |
| `bbr.healthCheckPort` | Port for health checks. Defaults to `9005`. |
| `bbr.image.name` | Name of the container image used. |
| `bbr.image.hub` | Registry URL where the image is hosted. |
| `bbr.image.tag` | Image tag. |
| `bbr.image.pullPolicy` | Image pull policy for the container. Possible values: `Always`, `IfNotPresent`, or `Never`. Defaults to `Always`. |
| `provider.name` | Name of the Inference Gateway implementation being used. Possible values: `istio`, `gke`. Defaults to `none`. |
| `inference-gateway.name` | The name of the Gateway. Defaults to `inference-gateway`. |
| `inference-gateway.name` | The name of the Gateway. Defaults to `inference-gateway`. |

## Notes

Expand Down
8 changes: 4 additions & 4 deletions config/charts/body-based-routing/templates/bbr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ spec:
- "v"
- "3"
ports:
- containerPort: 9004
- containerPort: {{ .Values.bbr.port }}
# health check
- containerPort: 9005
- containerPort: {{ .Values.bbr.healthCheckPort }}
---
apiVersion: v1
kind: Service
Expand All @@ -36,7 +36,7 @@ spec:
app: {{ .Values.bbr.name }}
ports:
- protocol: TCP
port: 9004
targetPort: 9004
port: {{ .Values.bbr.port }}
targetPort: {{ .Values.bbr.port }}
appProtocol: HTTP2
type: ClusterIP
4 changes: 2 additions & 2 deletions config/charts/body-based-routing/templates/gke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ spec:
group: ""
kind: Service
name: {{ .Values.bbr.name }}
port: 9004
port: {{ .Values.bbr.port }}
---
apiVersion: networking.gke.io/v1
kind: HealthCheckPolicy
Expand All @@ -40,7 +40,7 @@ spec:
type: "GRPC"
grpcHealthCheck:
portSpecification: "USE_FIXED_PORT"
port: 9005
port: {{ .Values.bbr.healthCheckPort }}
targetRef:
group: ""
kind: Service
Expand Down
2 changes: 1 addition & 1 deletion config/charts/body-based-routing/templates/istio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:
response_trailer_mode: "SKIP"
grpc_service:
envoy_grpc:
cluster_name: outbound|9004||{{ .Values.bbr.name }}.default.svc.cluster.local
cluster_name: outbound|{{ .Values.bbr.port }}||{{ .Values.bbr.name }}.default.svc.cluster.local
---
apiVersion: networking.istio.io/v1
kind: DestinationRule
Expand Down
3 changes: 2 additions & 1 deletion config/charts/body-based-routing/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ bbr:
hub: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension
tag: main
pullPolicy: Always
extProcPort: 9002
port: 9004
healthCheckPort: 9005

provider:
name: none
Expand Down