Skip to content

Add makefile configs for bbr helm chart #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Add makefile configs for bbr helm chart #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,10 @@ PHONY: inferencepool-helm-chart-push
inferencepool-helm-chart-push: yq helm
CHART=inferencepool EXTRA_TAG="$(EXTRA_TAG)" IMAGE_REGISTRY="$(IMAGE_REGISTRY)" YQ="$(YQ)" HELM="$(HELM)" ./hack/push-chart.sh

PHONY: bbr-helm-chart-push
bbr-helm-chart-push: yq helm
CHART=body-based-routing EXTRA_TAG="$(EXTRA_TAG)" IMAGE_REGISTRY="$(IMAGE_REGISTRY)" YQ="$(YQ)" HELM="$(HELM)" ./hack/push-chart.sh

##@ Release

.PHONY: release-quickstart
Expand Down
1 change: 1 addition & 0 deletions cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ steps:
entrypoint: make
args:
- inferencepool-helm-chart-push
- bbr-helm-chart-push
env:
- EXTRA_TAG=$_PULL_BASE_REF
- GOTOOLCHAIN=auto
Expand Down
6 changes: 6 additions & 0 deletions config/charts/body-based-routing/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ To install a body-based router named `body-based-router`, you can run the follow
$ helm install body-based-router ./config/charts/body-based-routing
```

To install via the latest published chart in staging (--version v0 indicates latest dev version), you can run the following command:

```txt
$ helm install body-based-router oci://us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/charts/body-based-router --version v0
```

## Uninstall

Run the following command to uninstall the chart:
Expand Down
3 changes: 1 addition & 2 deletions hack/push-chart.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ readonly semver_regex='^v([0-9]+)(\.[0-9]+){1,2}$'
chart_version=${CHART_VERSION}
if [[ ${EXTRA_TAG} =~ ${semver_regex} ]]
then
# This is a release branch, use the release version
${YQ} -i '.inferenceExtension.image.tag=strenv(EXTRA_TAG)' config/charts/inferencepool/values.yaml
${YQ} -i '.inferenceExtension.image.tag=strenv(EXTRA_TAG)' config/charts/${CHART}/values.yaml
chart_version=${EXTRA_TAG}
fi

Expand Down