Revert name change to make pool name more descriptive. #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of the CPU deployment path, we recently changed the name to
my-pool
which is so generic as to not mean much of anything.Reverting this change to give some context clues as to what an InferencePool is intended to house.
vllm-llama2-7b-pool
is fairly descriptive in what the pool contains.We will soon have helm charts: #416 so this name can be more configurable. But for the getting started guide in the short term I would rather make an opinionated decision on the naming.