Skip to content

feat: adds initial release automation #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Feb 5, 2025

  • .github/ISSUE_TEMPLATE/new-release.md: Updates the release github template.
  • Makefile: Adds targets to support initial release automation.
  • hack/release-quickstart.sh: A script to automate quickstart guide changes required for a release.

fixes: #291

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kfswain February 5, 2025 21:03
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2025
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit ec0717b
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67a3d231df086e000831f9dc
😎 Deploy Preview https://deploy-preview-291--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfswain
Copy link
Collaborator

kfswain commented Feb 5, 2025

Mostly just the patch version thing is what I saw, but overall lgtm! Thanks!

@danehans
Copy link
Contributor Author

danehans commented Feb 5, 2025

TestKubeInferenceModelRequest/success failed due to:

        hermetic_test.go:266: Unexpected response, (-want +got):   (*ext_procv3.ProcessingResponse)(Inverse(protocmp.Transform, protocmp.Message{
              	"@type": s"envoy.service.ext_proc.v3.ProcessingResponse",
              	"dynamic_metadata": protocmp.Message{
              		"@type": s"google.protobuf.Struct",
              		"fields": map[string]protocmp.Message{
              			"x-gateway-destination-endpoint": {
              				"@type":        s"google.protobuf.Value",
            - 				"string_value": string("pod-1:8000"),
            + 				"string_value": string("pod-2:8000"),
              			},
              		},
              	},

This failure is unrelated to the changes in this PR. Retesting to see if this is a flake.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025
@danehans
Copy link
Contributor Author

danehans commented Feb 5, 2025

/retest

@danehans
Copy link
Contributor Author

danehans commented Feb 5, 2025

@kfswain I had to rerun CI due to #291 (comment). This PR needs to be retagged.

@kfswain
Copy link
Collaborator

kfswain commented Feb 5, 2025

Ack on both accounts, happy to hold off on the patch version logic until needed. Who knows, maybe we never do 😎😎.
Feel free to unhold when ready.
/hold
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2025
@danehans
Copy link
Contributor Author

danehans commented Feb 6, 2025

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 056adfd into kubernetes-sigs:main Feb 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants