Bug in InferencePool Reconciler's short-circuit logic

[MaYuan-02]

Hi everyone,

I'm interested in this project and am currently exploring the existing implementation. I've identified an error in the InferencePool Reconciler and would be happy to work on a fix.

func (c *InferencePoolReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
	if req.NamespacedName.Name != c.ServerPoolName && req.NamespacedName.Namespace != c.Namespace {
		return ctrl.Result{}, nil
	}
...
}

The OR operator should be used here, right?

[ahg-g]

good catch, thanks for the fix!

[ahg-g]

/close

[k8s-ci-robot]

@ahg-g: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.