Skip to content

PoolRef is Required and a Pointer Type #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danehans opened this issue Dec 19, 2024 · 5 comments
Closed

PoolRef is Required and a Pointer Type #111

danehans opened this issue Dec 19, 2024 · 5 comments
Assignees
@kfswain

Comments

@danehans
Copy link
Contributor

According to API conventions, required fields should not be pointer types.
@danehans
Copy link
Contributor Author

/assign

@danehans danehans mentioned this issue Dec 19, 2024
Closed
@danehans danehans changed the title PoolObjectReference is Required and a Pointer Type PoolRef is Required and a Pointer Type Dec 19, 2024
@kfswain kfswain mentioned this issue Dec 19, 2024
Merged
@danehans
Copy link
Contributor Author

/assign @kfswain

@danehans
Copy link
Contributor Author

/unassign @danehans

@ahg-g
Copy link
Contributor

ahg-g commented Dec 19, 2024

/close

@k8s-ci-robot
Copy link
Contributor

@ahg-g: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kfswain kfswain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes PoolRef to a Value Type danehans/gateway-api-inference-extension
4 participants
@danehans @k8s-ci-robot @ahg-g @kfswain