[release-0.18] 🐛 Refactor certificate watcher to use polling, instead of fsnotify #3035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
k8s-ci-robot
added
the
cncf-cla: no
vincepri
changed the title
k8s-ci-robot
added
approved
vincepri
force-pushed
the
backport-018-3023
branch
from
78b2333 to
f655000
Compare
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
vincepri
force-pushed
the
backport-018-3023
branch
from
2bcd839 to
a586157
Compare
… of fsnotify (#3023) * Reestablish watch for the certificate paths * Remove fsnotify and use cached read watcher * Simplify return * 🐛Fix certwatcher test to be backwards compatible --------- Co-authored-by: Maxim Muzafarov <[email protected]> Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
backport-018-3023
branch
from
a586157 to
082726a
Compare
m-messiah
approved these changes
Dec 2, 2024
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f88e5be8f042ffc132bfd639f000a0927d728907
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: m-messiah, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of fsnotify (#3023)
Reestablish watch for the certificate paths
Remove fsnotify and use cached read watcher
Simplify return
🐛Fix certwatcher test to be backwards compatible